From: Carlos Llamas <cmllamas@google.com>
To: Pierre Gondois <pierre.gondois@arm.com>
Cc: linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <brauner@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Coly Li" <colyli@suse.de>,
"Kent Overstreet" <kent.overstreet@gmail.com>,
"Marco Elver" <elver@google.com>,
"Kees Cook" <keescook@chromium.org>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
linux-bcache@vger.kernel.org
Subject: Re: [PATCH v2 2/3] binder: Use of hlist_count_nodes()
Date: Thu, 4 Jan 2024 17:31:45 +0000 [thread overview]
Message-ID: <ZZbrgYTkhp_EH6Ci@google.com> (raw)
In-Reply-To: <20240104164937.424320-3-pierre.gondois@arm.com>
On Thu, Jan 04, 2024 at 05:49:34PM +0100, Pierre Gondois wrote:
> Make use of the newly added hlist_count_nodes().
>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
> drivers/android/binder.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 92128aae2d06..f9ca4d58d825 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -6077,9 +6077,7 @@ static void print_binder_node_nilocked(struct seq_file *m,
> struct binder_work *w;
> int count;
>
> - count = 0;
> - hlist_for_each_entry(ref, &node->refs, node_entry)
> - count++;
> + count = hlist_count_nodes(&node->refs);
>
> seq_printf(m, " node %d: u%016llx c%016llx hs %d hw %d ls %d lw %d is %d iw %d tr %d",
> node->debug_id, (u64)node->ptr, (u64)node->cookie,
> --
> 2.25.1
>
Looks good to me!
Acked-by: Carlos Llamas <cmllamas@google.com>
next prev parent reply other threads:[~2024-01-04 17:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 16:49 [PATCH v2 0/3] list: Add hlist_count_nodes() Pierre Gondois
2024-01-04 16:49 ` [PATCH v2 1/3] " Pierre Gondois
2024-01-04 17:30 ` Carlos Llamas
2024-01-05 6:53 ` Coly Li
2024-01-04 16:49 ` [PATCH v2 2/3] binder: Use of hlist_count_nodes() Pierre Gondois
2024-01-04 17:31 ` Carlos Llamas [this message]
2024-01-04 16:49 ` [PATCH v2 3/3] bcache: " Pierre Gondois
2024-01-05 6:55 ` Coly Li
2024-01-06 14:36 ` Andy Shevchenko
2024-01-04 17:16 ` [PATCH v2 0/3] list: Add hlist_count_nodes() Marco Elver
2024-01-08 7:00 ` Marco Elver
2024-01-06 14:37 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZbrgYTkhp_EH6Ci@google.com \
--to=cmllamas@google.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=colyli@suse.de \
--cc=elver@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=maco@android.com \
--cc=mingo@kernel.org \
--cc=pierre.gondois@arm.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.