All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
	"Patrick Steinhardt" <ps@pks.im>,
	"Chandra Pratap via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org,
	"Chandra Pratap" <chandrapratap376@gmail.com>,
	"Chandra Pratap" <chandrapratap3519@gmail.com>
Subject: Re: [PATCH v2] write-or-die: make GIT_FLUSH a Boolean environment variable
Date: Thu, 4 Jan 2024 12:35:17 -0500	[thread overview]
Message-ID: <ZZbsVfFpJNQHGGEn@nand.local> (raw)
In-Reply-To: <xmqq5y0a9qed.fsf@gitster.g>

On Wed, Jan 03, 2024 at 11:18:50AM -0800, Junio C Hamano wrote:
> > Thanks for a nice reading - I can not imagine a better version.
>
> Yup, the flow of the logic feels very natural with this version by
> making it clear that the case that the default "-1" is returned to
> us is where we need to figure out an appropriate value ourselves.
> An added bonus is that the scope "struct stat" has is limited to the
> absolute minimum.  I like it, too.

Thanks, both.

Thanks,
Taylor

  reply	other threads:[~2024-01-04 17:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-30 16:54 [PATCH] write-or-die: make GIT_FLUSH a Boolean environment variable Chandra Pratap via GitGitGadget
2024-01-01  8:24 ` Torsten Bögershausen
2024-01-02 16:29   ` Junio C Hamano
2024-01-03  7:58 ` [PATCH v2] " Chandra Pratap via GitGitGadget
2024-01-03  8:22   ` Patrick Steinhardt
2024-01-03 17:15     ` Taylor Blau
2024-01-03 18:42       ` Torsten Bögershausen
2024-01-03 19:18         ` Junio C Hamano
2024-01-04 17:35           ` Taylor Blau [this message]
2024-01-03 17:13   ` Junio C Hamano
2024-01-04 10:20   ` [PATCH v3] " Chandra Pratap via GitGitGadget
2024-01-04 17:36     ` Taylor Blau
2024-01-04 18:35     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZZbsVfFpJNQHGGEn@nand.local \
    --to=me@ttaylorr.com \
    --cc=chandrapratap3519@gmail.com \
    --cc=chandrapratap376@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=ps@pks.im \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.