From: Dominique Martinet <asmadeus@codewreck.org>
To: Matthew Wilcox <willy@infradead.org>,
David Howells <dhowells@redhat.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
Anna Schumaker <Anna.Schumaker@netapp.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Jeff Layton <jlayton@kernel.org>,
Steve French <smfrench@gmail.com>,
Marc Dionne <marc.dionne@auristor.com>,
Paulo Alcantara <pc@manguebit.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>,
Eric Van Hensbergen <ericvh@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
Christian Brauner <christian@brauner.io>,
linux-cachefs@redhat.com, linux-afs@lists.infradead.org,
linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
ceph-devel@vger.kernel.org, v9fs@lists.linux.dev,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix oops in NFS
Date: Sat, 6 Jan 2024 02:20:29 +0900 [thread overview]
Message-ID: <ZZg6XQOjlOA0CL17@codewreck.org> (raw)
In-Reply-To: <1197168.1704465212@warthog.procyon.org.uk> <ZZgBcJ7OAS7Ui6gi@casper.infradead.org>
Matthew Wilcox wrote on Fri, Jan 05, 2024 at 01:17:36PM +0000:
> host on /host type 9p (rw,relatime,access=client,trans=virtio)
David Howells wrote on Fri, Jan 05, 2024 at 02:33:32PM +0000:
> > This commit (100ccd18bb41 in linux-next 20240104) is bad for me. After
> > it, running xfstests gives me first a bunch of errors along these lines:
>
> This may be related to a patch that is in linux-next 20240105, but not
> 20240104 ("9p: Fix initialisation of netfs_inode for 9p").
Yes, you'd be reading zeroes without that patch because the netfs code
thinks the file has 0 size and doesn't bother reading, that'd explain
the exec format error loading other modules...
One thing that surprised me is that this also affects cache=none, I
thought we had different file ops going straight to p9_client_read in
this case?
But turning my brain on this would be the read-only mmap case that we
need to support for execs, which module loading also uses, so this came
biting there alright.
--
Dominique Martinet | Asmadeus
next prev parent reply other threads:[~2024-01-05 17:21 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 13:22 [PATCH v5 00/40] netfs, afs, 9p: Delegate high-level I/O to netfslib David Howells
2023-12-21 13:22 ` [PATCH v5 01/40] afs: Remove whitespace before most ')' from the trace header David Howells
2023-12-21 13:22 ` [PATCH v5 02/40] afs: Automatically generate trace tag enums David Howells
2023-12-21 13:22 ` [PATCH v5 03/40] netfs, fscache: Move fs/fscache/* into fs/netfs/ David Howells
2023-12-21 13:22 ` [PATCH v5 04/40] netfs, fscache: Combine fscache with netfs David Howells
2023-12-22 13:02 ` [PATCH] Fix EROFS Kconfig David Howells
2023-12-22 13:02 ` David Howells
2023-12-23 3:55 ` Jingbo Xu
2023-12-23 3:55 ` Jingbo Xu
2023-12-23 13:32 ` Gao Xiang
2023-12-23 13:32 ` Gao Xiang
2023-12-21 13:23 ` [PATCH v5 05/40] netfs, fscache: Remove ->begin_cache_operation David Howells
2023-12-21 13:23 ` [PATCH v5 06/40] netfs, fscache: Move /proc/fs/fscache to /proc/fs/netfs and put in a symlink David Howells
2024-01-03 16:49 ` Marc Dionne
2023-12-21 13:23 ` [PATCH v5 07/40] netfs: Move pinning-for-writeback from fscache to netfs David Howells
2023-12-21 13:23 ` [PATCH v5 08/40] netfs: Add a procfile to list in-progress requests David Howells
2023-12-21 13:23 ` [PATCH v5 09/40] netfs: Allow the netfs to make the io (sub)request alloc larger David Howells
2023-12-21 13:23 ` [PATCH v5 10/40] netfs: Add a ->free_subrequest() op David Howells
2023-12-21 13:23 ` [PATCH v5 11/40] afs: Don't use folio->private to record partial modification David Howells
2023-12-21 13:23 ` [PATCH v5 12/40] netfs: Provide invalidate_folio and release_folio calls David Howells
2023-12-21 13:23 ` [PATCH v5 13/40] netfs: Implement unbuffered/DIO vs buffered I/O locking David Howells
2023-12-21 13:23 ` [PATCH v5 14/40] netfs: Add iov_iters to (sub)requests to describe various buffers David Howells
2024-08-08 8:07 ` Christian Ebner
2024-08-12 13:01 ` Christian Ebner
2023-12-21 13:23 ` [PATCH v5 15/40] netfs: Add support for DIO buffering David Howells
2023-12-26 16:54 ` Nathan Chancellor
2023-12-28 10:47 ` Christian Brauner
2023-12-28 16:58 ` Nathan Chancellor
2023-12-21 13:23 ` [PATCH v5 16/40] netfs: Provide tools to create a buffer in an xarray David Howells
2023-12-21 13:23 ` [PATCH v5 17/40] netfs: Add func to calculate pagecount/size-limited span of an iterator David Howells
2023-12-21 13:23 ` [PATCH v5 18/40] netfs: Limit subrequest by size or number of segments David Howells
2023-12-21 13:23 ` [PATCH v5 19/40] netfs: Extend the netfs_io_*request structs to handle writes David Howells
2023-12-21 13:23 ` [PATCH v5 20/40] netfs: Add a hook to allow tell the netfs to update its i_size David Howells
2023-12-21 13:23 ` [PATCH v5 21/40] netfs: Make netfs_put_request() handle a NULL pointer David Howells
2023-12-21 13:23 ` [PATCH v5 22/40] netfs: Make the refcounting of netfs_begin_read() easier to use David Howells
2023-12-21 13:23 ` [PATCH v5 23/40] netfs: Prep to use folio->private for write grouping and streaming write David Howells
2023-12-21 13:23 ` [PATCH v5 24/40] netfs: Dispatch write requests to process a writeback slice David Howells
2023-12-21 13:23 ` [PATCH v5 25/40] netfs: Provide func to copy data to pagecache for buffered write David Howells
2023-12-21 13:23 ` [PATCH v5 26/40] netfs: Make netfs_read_folio() handle streaming-write pages David Howells
2023-12-21 13:23 ` [PATCH v5 27/40] netfs: Allocate multipage folios in the writepath David Howells
2023-12-21 13:23 ` [PATCH v5 28/40] netfs: Implement unbuffered/DIO read support David Howells
2023-12-21 13:23 ` [PATCH v5 29/40] netfs: Implement unbuffered/DIO write support David Howells
2023-12-21 13:23 ` [PATCH v5 30/40] netfs: Implement buffered write API David Howells
2023-12-21 13:23 ` [PATCH v5 31/40] netfs: Allow buffered shared-writeable mmap through netfs_page_mkwrite() David Howells
2023-12-21 13:23 ` [PATCH v5 32/40] netfs: Provide netfs_file_read_iter() David Howells
2023-12-21 13:23 ` [PATCH v5 33/40] netfs, cachefiles: Pass upper bound length to allow expansion David Howells
2024-01-02 14:04 ` Gao Xiang
2024-01-02 17:11 ` David Howells
2024-01-02 20:37 ` Gao Xiang
2024-01-03 9:18 ` Yiqun Leng
2024-01-03 10:15 ` Jia Zhu
2023-12-21 13:23 ` [PATCH v5 34/40] netfs: Provide a writepages implementation David Howells
2023-12-21 13:23 ` [PATCH v5 35/40] netfs: Provide a launder_folio implementation David Howells
2023-12-21 13:23 ` [PATCH v5 36/40] netfs: Implement a write-through caching option David Howells
2023-12-21 13:23 ` [PATCH v5 37/40] netfs: Optimise away reads above the point at which there can be no data David Howells
2023-12-21 23:01 ` Nathan Chancellor
2023-12-22 11:49 ` David Howells
2023-12-22 12:00 ` [PATCH] Fix oops in NFS David Howells
2024-01-05 4:52 ` Matthew Wilcox
2024-01-05 10:12 ` David Howells
2024-01-05 13:17 ` Matthew Wilcox
2024-01-05 17:20 ` Dominique Martinet [this message]
2024-01-05 11:48 ` David Howells
2024-01-05 14:33 ` David Howells
2023-12-21 13:23 ` [PATCH v5 38/40] netfs: Export the netfs_sreq tracepoint David Howells
2023-12-21 13:23 ` [PATCH v5 39/40] afs: Use the netfs write helpers David Howells
2023-12-21 13:23 ` [PATCH v5 40/40] 9p: Use netfslib read/write_iter David Howells
2024-01-02 15:39 ` David Howells
2024-01-02 21:49 ` [PATCH] 9p: Fix initialisation of netfs_inode for 9p David Howells
2024-01-03 13:10 ` Dominique Martinet
2024-01-03 13:59 ` David Howells
2024-01-03 14:04 ` David Howells
2024-01-03 7:22 ` [PATCH v5 40/40] 9p: Use netfslib read/write_iter Dominique Martinet
2024-01-03 12:08 ` David Howells
2024-01-03 12:39 ` David Howells
2024-01-03 13:00 ` Dominique Martinet
2024-01-03 19:52 ` Eric Van Hensbergen
2024-05-09 17:15 ` Andrea Righi
2024-05-09 21:33 ` David Howells
2024-05-10 5:53 ` Andrea Righi
2024-05-10 7:57 ` David Howells
2024-05-23 7:44 ` David Howells
2024-05-30 19:16 ` Emanuele Rocca
2024-05-31 15:06 ` Emanuele Rocca
2024-06-17 17:10 ` Christian Kastner
2024-06-17 21:50 ` Dominique Martinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZg6XQOjlOA0CL17@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=Anna.Schumaker@netapp.com \
--cc=ceph-devel@vger.kernel.org \
--cc=christian@brauner.io \
--cc=dhowells@redhat.com \
--cc=ericvh@kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pc@manguebit.com \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
--cc=trond.myklebust@hammerspace.com \
--cc=v9fs@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.