From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petre Rodan <petre.rodan@subdimension.ro>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Andreas Klinger <ak@it-klinger.de>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Angel Iglesias <ang.iglesiasg@gmail.com>,
Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: [PATCH v3 07/10] iio: pressure: mprls0025pa whitespace cleanup
Date: Sat, 6 Jan 2024 17:24:55 +0200 [thread overview]
Message-ID: <ZZlwx1JSdjAvto55@smile.fi.intel.com> (raw)
In-Reply-To: <20231229092445.30180-8-petre.rodan@subdimension.ro>
On Fri, Dec 29, 2023 at 11:24:35AM +0200, Petre Rodan wrote:
> Fix indentation and whitespace in code that will not get refactored.
>
> Make URL inside comment copy-paste friendly.
...
> ret = devm_request_irq(dev, data->irq, mpr_eoc_handler,
> - IRQF_TRIGGER_RISING, client->name, data);
> + IRQF_TRIGGER_RISING,
> + client->name,
> + data);
The last two are perfectly located on a single line and be even coupled
semantically together.
No need to resend the patch just because of this, Jonathan can amend, I think,
when applying.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-01-06 15:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 9:24 [PATCH v3 00/10] changes to mprls0025pa Petre Rodan
2023-12-29 9:24 ` [PATCH v3 01/10] dt-bindings: iio: pressure: honeywell,mprls0025pa.yaml improvements Petre Rodan
2023-12-29 9:24 ` [PATCH v3 02/10] dt-bindings: iio: pressure: honeywell,mprls0025pa.yaml add pressure-triplet Petre Rodan
2024-01-04 8:26 ` Krzysztof Kozlowski
2023-12-29 9:24 ` [PATCH v3 03/10] dt-bindings: iio: pressure: honeywell,mprls0025pa.yaml add spi bus Petre Rodan
2024-01-04 8:26 ` Krzysztof Kozlowski
2023-12-29 9:24 ` [PATCH v3 04/10] iio: pressure: mprls0025pa fix off-by-one enum Petre Rodan
2023-12-29 9:24 ` [PATCH v3 05/10] iio: pressure: mprls0025pa improve driver error resilience Petre Rodan
2023-12-29 9:24 ` [PATCH v3 06/10] iio: pressure: mprls0025pa remove defaults Petre Rodan
2023-12-29 9:24 ` [PATCH v3 07/10] iio: pressure: mprls0025pa whitespace cleanup Petre Rodan
2024-01-06 15:24 ` Andy Shevchenko [this message]
2023-12-29 9:24 ` [PATCH v3 08/10] iio: pressure: mprls0025pa refactor Petre Rodan
2023-12-29 9:24 ` [PATCH v3 09/10] iio: pressure: mprls0025pa add triplet property Petre Rodan
2023-12-29 9:24 ` [PATCH v3 10/10] iio: pressure: mprls0025pa add SPI driver Petre Rodan
2024-01-06 15:30 ` Andy Shevchenko
2024-01-06 16:02 ` Petre Rodan
2024-01-06 16:07 ` Andy Shevchenko
2024-01-07 16:32 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZlwx1JSdjAvto55@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ak@it-klinger.de \
--cc=ang.iglesiasg@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=petre.rodan@subdimension.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.