All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
	Jun'ichi Nomura <junichi.nomura@nec.com>,
	Derek Barbosa <debarbos@redhat.com>,
	Kees Cook <keescook@chromium.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Andy Lutomirski <luto@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>,
	x86@kernel.org
Subject: Re: [tip: x86/boot] x86/boot: Ignore NMIs during very early boot
Date: Mon, 8 Jan 2024 12:08:07 +0100	[thread overview]
Message-ID: <ZZvXlyW8Khmr805c@gmail.com> (raw)
In-Reply-To: <20231130103339.GCZWhlA196uRklTMNF@fat_crate.local>


* Borislav Petkov <bp@alien8.de> wrote:

> On Thu, Nov 30, 2023 at 08:59:44AM -0000, tip-bot2 for Jun'ichi Nomura wrote:
> > +void do_boot_nmi_trap(struct pt_regs *regs, unsigned long error_code)
> > +{
> > +	/* Empty handler to ignore NMI during early boot */
> 
> It might be good to issue something here to say that a spurious NMI got
> ignored.
> 
> Something ala
> 
> 	error_putstr("Spurious early NMI ignored.\n");
> 
> so that we at least say that we ignored an NMI and not have it disappear
> unnoticed.

That makes sense. Jun'ichi-san, could you please send a patch for this?

Thanks,

	Ingo

  reply	other threads:[~2024-01-08 11:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30  8:59 [tip: x86/boot] x86/boot: Ignore NMIs during very early boot tip-bot2 for Jun'ichi Nomura
2023-11-30 10:33 ` Borislav Petkov
2024-01-08 11:08   ` Ingo Molnar [this message]
2024-01-09  5:17     ` NOMURA JUNICHI(野村　淳一)
2024-01-12 11:25       ` NOMURA JUNICHI(野村　淳一)
2024-02-06 10:01   ` [tip: x86/boot] x86/boot: Add a message about ignored early NMIs tip-bot2 for NOMURA JUNICHI(野村 淳一)
2024-04-03  6:32   ` [tip: x86/boot] x86/boot: Ignore NMIs during very early boot Zeng Heng
2024-04-03 10:41     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZZvXlyW8Khmr805c@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=debarbos@redhat.com \
    --cc=hpa@zytor.com \
    --cc=junichi.nomura@nec.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.