From: Johan Hovold <johan@kernel.org>
To: rujra <braker.noob.kernel@gmail.com>
Cc: ayushdevel1325@gmail.com, elder@kernel.org,
gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org,
outreachy@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [FIRST-PATCH] staging : greybus : gb-beagleplay.c : fixing the checks as first-patch
Date: Wed, 16 Apr 2025 15:51:17 +0200 [thread overview]
Message-ID: <Z_-11fvQJtiwAxaA@hovoldconsulting.com> (raw)
In-Reply-To: <CAG+54DbvpWHyX8+ucEQpg2B6rNTJP11CRpYxcYVrKpKehzrK-A@mail.gmail.com>
On Wed, Apr 16, 2025 at 05:47:41PM +0530, rujra wrote:
> added comments on spinlocks for producer-consumer model, rearranged the
> lines on function calls where it should not end with "(" this bracket,
> also removed white-spaces and aligned the arguments of function calls.
>
> Signed-off-by: Rujra Bhatt <braker.noob.kernel@gmail.com>
You're doing too many things in one patch, the patch is white space
damaged, and the patch prefix is wrong since this driver does not live
in staging.
If you want to practise creating patches, please make sure to work in
drivers/staging where changes like these may be accepted.
Johan
next prev parent reply other threads:[~2025-04-16 13:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 12:17 [FIRST-PATCH] staging : greybus : gb-beagleplay.c : fixing the checks as first-patch rujra
2025-04-16 13:43 ` Ayush Singh
2025-04-16 13:45 ` Julia Lawall
2025-04-16 13:51 ` Johan Hovold [this message]
[not found] ` <CAG+54DbMYHDRMs+P1GcSYdqKJn+EBNA2xxXZfeWCX4DK+b31+g@mail.gmail.com>
2025-04-16 17:11 ` [greybus-dev] " Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_-11fvQJtiwAxaA@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=ayushdevel1325@gmail.com \
--cc=braker.noob.kernel@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.