From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20110C369A2 for ; Mon, 14 Apr 2025 16:57:43 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.950930.1347098 (Exim 4.92) (envelope-from ) id 1u4N7h-0008Vd-Ep; Mon, 14 Apr 2025 16:57:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 950930.1347098; Mon, 14 Apr 2025 16:57:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1u4N7h-0008VW-Ar; Mon, 14 Apr 2025 16:57:29 +0000 Received: by outflank-mailman (input) for mailman id 950930; Mon, 14 Apr 2025 16:57:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1u4N7g-0008VP-GC for xen-devel@lists.xenproject.org; Mon, 14 Apr 2025 16:57:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1u4N7f-00EyIu-2u; Mon, 14 Apr 2025 16:57:27 +0000 Received: from [2a01:e0a:1da:8420:b77:bd5:6e45:7633] (helo=l14) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u4N7f-00GJiv-1v; Mon, 14 Apr 2025 16:57:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=vYEY+HR6qgtd6JjfOtYgs7C/AAwqxupyDV4G4O2eBfc=; b=iPTqBY/82X4hTFlTFFqhdJdT0M qiRwBjelZ57ZQQnwhuEXGeEhm3NEgZMHVtT+i2lJqnvciVICmMX0lyBlddy7PPZmbfIsg6LqJ4Q+5 kO6fzZ7EoetW46SYtBhmpz7Gen+YaxcHLmubQsDbP/9uhCduLtG5DASuXdN6fWkfw27k=; Date: Mon, 14 Apr 2025 18:57:25 +0200 From: Anthony PERARD To: Andrew Cooper Cc: Xen-devel , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , Anthony PERARD , Stefano Stabellini , Michal Orzel , Doug Goldstein Subject: Re: [PATCH v3 2/6] CI: avoid repacking initrd as part of the test job Message-ID: References: <20250414110903.2355303-1-andrew.cooper3@citrix.com> <20250414110903.2355303-3-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250414110903.2355303-3-andrew.cooper3@citrix.com> On Mon, Apr 14, 2025 at 12:08:59PM +0100, Andrew Cooper wrote: > From: Marek Marczykowski-Górecki > > Use the new test-artifacts which provide rootfs.cpio.gz rather than > initrd.tar.gz. rootfs.cpio.gz also has all the necessary top-level > directories, and includes the rc_verbose setting, so these modifications can > be dropped. > > Having that, do not repack the whole initrd, but only pack modified > files and rely on Linux handling of concatenated archives. > This allows packing just test-related files (which includes the whole > toolstack), instead of the whole initrd. > > For xilinx-smoke-dom0-x86_64.sh, this involves instructing grub not to unzip > the archive, as doing so corrupts it. > > Signed-off-by: Marek Marczykowski-Górecki > Signed-off-by: Andrew Cooper This patch seems to depends on the other patch series for "test-artifacts" repo. I've tried to compare the rootfs fs generated by this repo, and the one generated in the "test-artifacts" repo, and I think there's a few changes, at least for the arm64 rootfs as the changes have probably already sailed for x86_64, namely: Those don't exist in the new rootfs: rc-update add networking sysinit rc-update add modloop sysinit rc-update add modules boot rc-update add sysctl boot There's `echo > /etc/modules` been added. But I guess none of those matter, as it already works on x86_64 tests. Overall, looks good, more common code between tests! Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD