From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Simon Ser <contact@emersion.fr>
Cc: dri-devel@lists.freedesktop.org,
Pekka Paalanen <pekka.paalanen@collabora.com>,
Simona Vetter <simona.vetter@ffwll.ch>
Subject: Re: [PATCH v2] drm/doc: document front-buffer rendering
Date: Mon, 14 Apr 2025 16:28:55 +0300 [thread overview]
Message-ID: <Z_0Nl9Z8GFoiaxTs@intel.com> (raw)
In-Reply-To: <20250414085652.43904-1-contact@emersion.fr>
On Mon, Apr 14, 2025 at 08:56:56AM +0000, Simon Ser wrote:
> Explain how to perform front-buffer rendering.
>
> v2: apply Pekka's rewrite
>
> Signed-off-by: Simon Ser <contact@emersion.fr>
> Cc: Pekka Paalanen <pekka.paalanen@collabora.com>
> Cc: Simona Vetter <simona.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/drm_blend.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c
> index 6e74de833466..4e83f372ea51 100644
> --- a/drivers/gpu/drm/drm_blend.c
> +++ b/drivers/gpu/drm/drm_blend.c
> @@ -75,6 +75,12 @@
> * the currently visible vertical area of the &drm_crtc.
> * FB_ID:
> * Mode object ID of the &drm_framebuffer this plane should scan out.
> + *
> + * When a KMS client is perfoming front-buffer rendering, it should set
> + * FB_ID to the same front-buffer FB on each atomic commit. This implies
> + * to the driver that it needs to re-read the same FB again. Otherwise
> + * drivers which do not employ continuously repeated scanout cycles might
> + * not update the screen.
Should probably add a caveat that this needs to be a sync commit/flip.
The way the async flip was specified for atomic explicitly requires the
driver to ignore the plane when the fb doesn't change.
Also use dirtyfb instead if you don't want to get throttled to the
vrefresh rate. Tthough I think with some drivers you might get
throttled even with dirtyfb...
> * CRTC_ID:
> * Mode object ID of the &drm_crtc this plane should be connected to.
> *
> --
> 2.49.0
>
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2025-04-14 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 8:56 [PATCH v2] drm/doc: document front-buffer rendering Simon Ser
2025-04-14 11:06 ` Pekka Paalanen
2025-04-17 15:19 ` Simon Ser
2025-04-22 11:05 ` Pekka Paalanen
2025-04-30 21:37 ` Simon Ser
2025-04-14 13:28 ` Ville Syrjälä [this message]
2025-04-14 14:51 ` Simona Vetter
2025-05-01 11:25 ` Simon Ser
2025-05-06 13:56 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_0Nl9Z8GFoiaxTs@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=contact@emersion.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=pekka.paalanen@collabora.com \
--cc=simona.vetter@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.