From: Brian Norris <briannorris@chromium.org>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Jeff Johnson <jjohnson@kernel.org>,
Loic Poulain <loic.poulain@linaro.org>,
Francesco Dolcini <francesco@dolcini.it>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
ath10k@lists.infradead.org, linux-kernel@vger.kernel.org,
ath11k@lists.infradead.org, ath12k@lists.infradead.org,
wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next 0/7] net: Don't use %pK through printk
Date: Mon, 14 Apr 2025 11:44:24 -0700 [thread overview]
Message-ID: <Z_1XiNY2ujreEo69@google.com> (raw)
In-Reply-To: <20250414-restricted-pointers-net-v1-0-12af0ce46cdd@linutronix.de>
On Mon, Apr 14, 2025 at 10:26:01AM +0200, Thomas Weißschuh wrote:
> Furthermore, restricted pointers ("%pK") were never meant to be used
> through printk().
Is this really true? Documentation/admin-guide/sysctl/kernel.rst still
has a section on kptr_restrict which talks about dmesg, CAP_SYSLOG, and
%pK, which sounds like it's intended. But I'm not highly familiar with
this space, so maybe I'm misreading something.
(I do see that commit a48849e2358e ("printk: clarify the documentation
for plain pointer printing") updated
Documentation/core-api/printk-formats.rst.)
In any case, even if the advice has changed, it seems (again, to an
outsider) a bit much to say it was "never" meant to be used through
printk().
Brian
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Jeff Johnson <jjohnson@kernel.org>,
Loic Poulain <loic.poulain@linaro.org>,
Francesco Dolcini <francesco@dolcini.it>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
ath10k@lists.infradead.org, linux-kernel@vger.kernel.org,
ath11k@lists.infradead.org, ath12k@lists.infradead.org,
wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH net-next 0/7] net: Don't use %pK through printk
Date: Mon, 14 Apr 2025 11:44:24 -0700 [thread overview]
Message-ID: <Z_1XiNY2ujreEo69@google.com> (raw)
In-Reply-To: <20250414-restricted-pointers-net-v1-0-12af0ce46cdd@linutronix.de>
On Mon, Apr 14, 2025 at 10:26:01AM +0200, Thomas Weißschuh wrote:
> Furthermore, restricted pointers ("%pK") were never meant to be used
> through printk().
Is this really true? Documentation/admin-guide/sysctl/kernel.rst still
has a section on kptr_restrict which talks about dmesg, CAP_SYSLOG, and
%pK, which sounds like it's intended. But I'm not highly familiar with
this space, so maybe I'm misreading something.
(I do see that commit a48849e2358e ("printk: clarify the documentation
for plain pointer printing") updated
Documentation/core-api/printk-formats.rst.)
In any case, even if the advice has changed, it seems (again, to an
outsider) a bit much to say it was "never" meant to be used through
printk().
Brian
next prev parent reply other threads:[~2025-04-14 19:11 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 8:26 [PATCH net-next 0/7] net: Don't use %pK through printk Thomas Weißschuh
2025-04-14 8:26 ` [Intel-wired-lan] " Thomas Weißschuh
2025-04-14 8:26 ` [PATCH net-next 1/7] wifi: ath10k: " Thomas Weißschuh
2025-04-14 8:26 ` [Intel-wired-lan] " Thomas Weißschuh
2025-04-14 16:16 ` Loktionov, Aleksandr
2025-04-14 16:16 ` Loktionov, Aleksandr
2025-04-14 8:26 ` [PATCH net-next 2/7] wifi: ath11k: " Thomas Weißschuh
2025-04-14 8:26 ` [Intel-wired-lan] " Thomas Weißschuh
2025-04-14 16:17 ` Loktionov, Aleksandr
2025-04-14 16:17 ` Loktionov, Aleksandr
2025-04-14 8:26 ` [PATCH net-next 3/7] wifi: ath12k: " Thomas Weißschuh
2025-04-14 8:26 ` [Intel-wired-lan] " Thomas Weißschuh
2025-04-14 16:16 ` Loktionov, Aleksandr
2025-04-14 16:16 ` Loktionov, Aleksandr
2025-04-14 8:26 ` [PATCH net-next 4/7] wifi: wcn36xx: " Thomas Weißschuh
2025-04-14 8:26 ` [Intel-wired-lan] " Thomas Weißschuh
2025-04-14 19:04 ` Loic Poulain
2025-04-14 19:04 ` [Intel-wired-lan] " Loic Poulain
2025-04-14 8:26 ` [PATCH net-next 5/7] wifi: mwifiex: " Thomas Weißschuh
2025-04-14 8:26 ` [Intel-wired-lan] " Thomas Weißschuh
2025-04-14 16:15 ` Loktionov, Aleksandr
2025-04-14 16:15 ` Loktionov, Aleksandr
2025-04-14 8:26 ` [PATCH net-next 6/7] ice: Don't use %pK through printk or tracepoints Thomas Weißschuh
2025-04-14 8:26 ` [Intel-wired-lan] " Thomas Weißschuh
2025-04-14 9:59 ` Przemek Kitszel
2025-04-14 9:59 ` [Intel-wired-lan] " Przemek Kitszel
2025-04-14 16:18 ` Loktionov, Aleksandr
2025-04-14 16:18 ` Loktionov, Aleksandr
2025-04-14 8:26 ` [PATCH net-next 7/7] net/mlx5: Don't use %pK through tracepoints Thomas Weißschuh
2025-04-14 8:26 ` [Intel-wired-lan] " Thomas Weißschuh
2025-04-14 10:49 ` Tariq Toukan
2025-04-14 10:49 ` [Intel-wired-lan] " Tariq Toukan
2025-04-14 16:17 ` Loktionov, Aleksandr
2025-04-14 16:17 ` Loktionov, Aleksandr
2025-04-14 15:02 ` [PATCH net-next 0/7] net: Don't use %pK through printk Jeff Johnson
2025-04-14 15:02 ` [Intel-wired-lan] " Jeff Johnson
2025-04-15 6:42 ` Thomas Weißschuh
2025-04-15 6:42 ` [Intel-wired-lan] " Thomas Weißschuh
2025-04-14 16:17 ` Loktionov, Aleksandr
2025-04-14 16:17 ` Loktionov, Aleksandr
2025-04-14 18:44 ` Brian Norris [this message]
2025-04-14 18:44 ` Brian Norris
2025-04-15 6:59 ` Thomas Weißschuh
2025-04-15 6:59 ` [Intel-wired-lan] " Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_1XiNY2ujreEo69@google.com \
--to=briannorris@chromium.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=ath12k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=francesco@dolcini.it \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jjohnson@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=thomas.weissschuh@linutronix.de \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.