From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51D01C369B4 for ; Mon, 14 Apr 2025 19:11:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YpSfHpLk4g82/Efaxxr4vcOeA7lwSVP0ZoulsVdeGLY=; b=C8Zv73vmoEaY3i4xLYbrGHmCWE MnUf0V/WSDvgRr2JGo6w5sUHpwQWN1HAbGEhjwo7n41WIhvoU4zICuRL6Di6CCPDAd8za9dBVsrlp czaxvXnjTpPiS7N69OLngcnoG6xmDKCdnESr9q/FqJZOG66nXxEn1074hn/vuxx+6+gk2bzEYsqeW xuaWVW/IvWz+6/sfKqrUVHXcxUQZgaCtCjemoAa99NZCDcriCspBwpzSsLIwTlOFEP/T98DySuGF5 wXMHXsZGTGMncwuOA/BFe+CDa6iInW0Wbi5lB4GoEBWQ9xaOqvor8LX2YGQgcLOqgQ0GtsKM74Srj 6Ob15+lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4PD9-00000003Eoz-1XEC; Mon, 14 Apr 2025 19:11:15 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4OnG-000000039YX-0L2E for ath10k@lists.infradead.org; Mon, 14 Apr 2025 18:44:32 +0000 Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-7fd581c2bf4so4048830a12.3 for ; Mon, 14 Apr 2025 11:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1744656269; x=1745261069; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=YpSfHpLk4g82/Efaxxr4vcOeA7lwSVP0ZoulsVdeGLY=; b=KNDb+73A5TzuqB4z0jvGdsjDjmmCbYFKmN1im6jhxImSRfVtn9d+V6WZtJ5AXTsp/Q ZiU1nrwTM/4jYiokNwLN/DUiFUK7t2BGJS/irKRmBDlmdd4hgNmNnju+/ZOeJWBaGa4J jbEE1LY77wrfSSe96otTWAsNDnz5NPBJs5y5I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744656269; x=1745261069; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YpSfHpLk4g82/Efaxxr4vcOeA7lwSVP0ZoulsVdeGLY=; b=FJY66sxcpfXcdKQzMdBByKqqfZr5GQp1MM7nm2dBIkdZa2OKZPGjBWv7ywdiBGIBz2 DmUfCA0A6NXK+CEZ3y8mma6sCR1iqhw3NKy+rpigwDkqbibs+loYb8AeT3jbWwX6G/pl sVf6WkLRpATTRXfkwEu5eRtx1TqN6sDGwf9fAzblTsd9rbuiXdFpswFkjolAxPYSO5eu JWF5mTIebpTvowt5nKMHDo1piTjl+LmoO8M1bjuq4fsnJK/0nYyATl7JLt4/ZFBsB3z2 L132VBefseec4RHYX7L5qajYvo5t6mNGN9cTROP3qLElS8VKkButi+jdBiPZdgE3D4Qy UcJQ== X-Forwarded-Encrypted: i=1; AJvYcCWq817PcPOj9wiRv5RMwvEdUD2+Xqc6XqmMehzHNrB+d7r8q+NRUslYTwv3cXbtpDKNSH6n77Y=@lists.infradead.org X-Gm-Message-State: AOJu0Yw21eEg7/+RBp8Sl34NnqzhmFsWiuRk4d09irvOJ7EuHi5IP5uA +X66p8KmKcPsllq5/UjSL2M9df5mYkKteiXlPXEAn56kivxn7Dus7SI9RGJUNA== X-Gm-Gg: ASbGncvUbPZ1u4QyeWzm7H6LxcO1SUQ9hGAqCyA03cImANPlcmcKDDwBj8tFy17Uwgx Tao64dK/KqF5mCzhG8b3AOyRZiqhWPPcKGd7PbUXf/c9LaGOhQ3ZHmCpyPOE2af3A8nunabf6Gf Zu5fY6mhNfHwRo+ON4tLgE2ep+oxYZ5MgOG7TwZUcjFsrv1F7fKN6FkivZpEuObZ6koQ1NkR6Pb w20q1t2P1N/4T+IW+JlzRFzxBlryzWTigTSx48ZFrBaG7WVjY4aci9QiuXvKpZSDENORwr8F0WN 4O7WtEaZwaOAwd2qBpX+dPr1+maaIU/PZ22hXRjA4H3YEMMxh/Q7LiWJiKOj6U6jZre4cGL9WTn 5SA== X-Google-Smtp-Source: AGHT+IHRnGevNVFCEzzLtuARDY+GV3b1ySMboNdXjtt9nCxP859MMeYdEqvd7RpkkuyGR22MEOT6ZQ== X-Received: by 2002:a17:90b:2752:b0:301:1bce:c255 with SMTP id 98e67ed59e1d1-308237ba788mr18304386a91.27.1744656268888; Mon, 14 Apr 2025 11:44:28 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:cfd0:cb73:1c0:728a]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-306df082327sm11386410a91.15.2025.04.14.11.44.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Apr 2025 11:44:27 -0700 (PDT) Date: Mon, 14 Apr 2025 11:44:24 -0700 From: Brian Norris To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Jeff Johnson , Loic Poulain , Francesco Dolcini , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , ath10k@lists.infradead.org, linux-kernel@vger.kernel.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH net-next 0/7] net: Don't use %pK through printk Message-ID: References: <20250414-restricted-pointers-net-v1-0-12af0ce46cdd@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250414-restricted-pointers-net-v1-0-12af0ce46cdd@linutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250414_114430_134936_5B74CD3B X-CRM114-Status: UNSURE ( 9.22 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org On Mon, Apr 14, 2025 at 10:26:01AM +0200, Thomas Weißschuh wrote: > Furthermore, restricted pointers ("%pK") were never meant to be used > through printk(). Is this really true? Documentation/admin-guide/sysctl/kernel.rst still has a section on kptr_restrict which talks about dmesg, CAP_SYSLOG, and %pK, which sounds like it's intended. But I'm not highly familiar with this space, so maybe I'm misreading something. (I do see that commit a48849e2358e ("printk: clarify the documentation for plain pointer printing") updated Documentation/core-api/printk-formats.rst.) In any case, even if the advice has changed, it seems (again, to an outsider) a bit much to say it was "never" meant to be used through printk(). Brian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 570A6C369A2 for ; Mon, 14 Apr 2025 18:46:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id EEB1E60BD4; Mon, 14 Apr 2025 18:46:34 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id jVT7CtZcy2tN; Mon, 14 Apr 2025 18:46:34 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 020FA60B24 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1744656394; bh=YpSfHpLk4g82/Efaxxr4vcOeA7lwSVP0ZoulsVdeGLY=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rBASfiNR+i1LKjxs0sWusEbXqMQ6suinjPEwh45Aer6GxM1SqrtLgP+h985LKAMkW 5Wgv09uQ6mMSD6zMJFfPEJcvkOokE6LpfI4FjNUeDhzXVVxeJ7x3R/X3jO6hjvwLuH 6U6o8mMi+Y5SaF6X6wq/FCLf7C+vc/InFQMwa3KQtK72P+pWz7PiWUqt/0YM/6vEC9 mryAUQIy41zfMgTYCWOQ0B1SCkwf/u/OnAxbv/fBwA5d7pgKxbdzZooXOw9W+doGYM 4ts9si0g/B02vuggLJCgoaQ6ZLGwD0lqersOfgj+lbI02G5v+t5pXaz//WaE4q59MM ha5xuBqCqvliA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 020FA60B24; Mon, 14 Apr 2025 18:46:34 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists1.osuosl.org (Postfix) with ESMTP id 3A986205 for ; Mon, 14 Apr 2025 18:44:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3704B813A2 for ; Mon, 14 Apr 2025 18:44:30 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Zvv9lrcdCAdP for ; Mon, 14 Apr 2025 18:44:29 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::529; helo=mail-pg1-x529.google.com; envelope-from=briannorris@chromium.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 8D49A80A47 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8D49A80A47 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by smtp1.osuosl.org (Postfix) with ESMTPS id 8D49A80A47 for ; Mon, 14 Apr 2025 18:44:29 +0000 (UTC) Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-b07d607dc83so1349965a12.1 for ; Mon, 14 Apr 2025 11:44:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744656269; x=1745261069; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YpSfHpLk4g82/Efaxxr4vcOeA7lwSVP0ZoulsVdeGLY=; b=lt0zJrfc4KQl/b3BBtBGq39zOKqNrtgG7vctv+gKuilAz6dcqYV0RX7+C9ZNXna/ma bK5ur+bllRAjnFKva6DLAW/uoX+SMseHzA5CcSUvG/vdozeriRYcye78MWUa1AfxQ9rx 9MWeCAAS0pEndoRvuhvAWJQ/lxphKIBVz18MbgvFQfBk882iCkSzNGnPEaxpnpy5nhoo UtPLTuRZcAilcFIZ4mRfSyfMSLlJjfm+AjIOwClXBGxV5J8//v2izjfrzGjpmCR8h2sq ZAACgh+AtUjTCBMfPElM8I6ec4Hn30CdwDrZUn9/o6cmN/KdhzUF2bXxOS9MBKlil8DR PGYg== X-Forwarded-Encrypted: i=1; AJvYcCWE8GUYTXWPKFF/WzwXIZ5SejSVOklK0Yu5cGPfBZVl2HhRGykoEd9TxeNkkDKtgzRhCsmzYIGf1gnjd8NSViM=@lists.osuosl.org X-Gm-Message-State: AOJu0YzEoOy92vhk1B/EEDXcb3FdFLOeFy4HseTsrYqv2UWqXDGc7H8+ bCmbUj/xbSiBj3ir3tc8//AhFLcGW1ULONMscpImea2NgQFgaGpgPXfe3dRTbA== X-Gm-Gg: ASbGncuo8j66A2eCkNNDg//kgpztHYlkGm31Y7gwWV4d7oIj+MIo+o/pPOr+lMXkdLY Scq+POeGEoU2yBLI9j99F/qLlr5QAa51bo/CZ/0x5MGUGq0H7AegK/kbAPrpfaHN3yt/O2ubEO9 IVbxCZ31dw7Iq/vlpdk3Z6lljyEwdG3+IebOFvPG3GL1BQD9Gnxv7MYTeF7ntwHfnHFDmrY3lYf +OSQvbK3T/PawQyz9uKKCfd8h3zAIOocZCoNOfgExSURZ0eunD9aEHSYaWZsxERgPaJau2UCkG4 DAIVmDv7cADE+Kaohp/YKufAXkHZLU2r+3rFEBRwXDOuoW6o85Oty1vsijkc/U7aRWRCG1m8Yss 7MA== X-Google-Smtp-Source: AGHT+IHRnGevNVFCEzzLtuARDY+GV3b1ySMboNdXjtt9nCxP859MMeYdEqvd7RpkkuyGR22MEOT6ZQ== X-Received: by 2002:a17:90b:2752:b0:301:1bce:c255 with SMTP id 98e67ed59e1d1-308237ba788mr18304386a91.27.1744656268888; Mon, 14 Apr 2025 11:44:28 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:cfd0:cb73:1c0:728a]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-306df082327sm11386410a91.15.2025.04.14.11.44.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Apr 2025 11:44:27 -0700 (PDT) Date: Mon, 14 Apr 2025 11:44:24 -0700 From: Brian Norris To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Jeff Johnson , Loic Poulain , Francesco Dolcini , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , ath10k@lists.infradead.org, linux-kernel@vger.kernel.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org Message-ID: References: <20250414-restricted-pointers-net-v1-0-12af0ce46cdd@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250414-restricted-pointers-net-v1-0-12af0ce46cdd@linutronix.de> X-Mailman-Approved-At: Mon, 14 Apr 2025 18:46:32 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1744656269; x=1745261069; darn=lists.osuosl.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=YpSfHpLk4g82/Efaxxr4vcOeA7lwSVP0ZoulsVdeGLY=; b=lV0Xwgi0KZN/8hDnVahCNWGUrhUf/YB/JZjFAvYkbgIXEiyqR6REhLurscxcPd34W+ 2lcxIznra9v15EGjD8gGVncAJ1dYZLJn4bu+Q2OVU16uevJf/ft0f78aBfywm66JhmTh JmH5gklRJLVJVKi2Bs/iQnuc5QFfwQ053akCQ= X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=chromium.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=lV0Xwgi0 Subject: Re: [Intel-wired-lan] [PATCH net-next 0/7] net: Don't use %pK through printk X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Apr 14, 2025 at 10:26:01AM +0200, Thomas Weißschuh wrote: > Furthermore, restricted pointers ("%pK") were never meant to be used > through printk(). Is this really true? Documentation/admin-guide/sysctl/kernel.rst still has a section on kptr_restrict which talks about dmesg, CAP_SYSLOG, and %pK, which sounds like it's intended. But I'm not highly familiar with this space, so maybe I'm misreading something. (I do see that commit a48849e2358e ("printk: clarify the documentation for plain pointer printing") updated Documentation/core-api/printk-formats.rst.) In any case, even if the advice has changed, it seems (again, to an outsider) a bit much to say it was "never" meant to be used through printk(). Brian