From: Jordan Rife <jordan@jrife.io>
To: Martin KaFai Lau <martin.lau@linux.dev>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
Aditi Ghag <aditi.ghag@isovalent.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>
Subject: Re: [PATCH v2 bpf-next 5/5] selftests/bpf: Add tests for bucket resume logic in UDP socket iterators
Date: Mon, 14 Apr 2025 17:04:16 -0700 [thread overview]
Message-ID: <Z_2igISGVwL9yqM-@t14> (raw)
In-Reply-To: <315cc79b-fc63-4164-9725-8b5fe2fb27f9@linux.dev>
> > +static int read_n(int iter_fd, int n, struct sock_count counts[],
> > + int counts_len)
> > +{
> > + struct iter_out out;
> > + int nread = 1;
> > + int i = 0;
> > +
> > + for (; nread > 0 && (n < 0 || i < n); i++) {
> > + nread = read(iter_fd, &out, sizeof(out));
> > + if (!nread || !ASSERT_GE(nread, 1, "nread"))
>
> why checks nread >= 1 instead of nread == sizeof(out)?
Will adjust this check to be more precise and apply the other changes
you mentioned.
Thanks!
-Jordan
prev parent reply other threads:[~2025-04-15 0:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 17:35 [PATCH v2 bpf-next 0/5] bpf: udp: Exactly-once socket iteration Jordan Rife
2025-04-11 17:35 ` [PATCH v2 bpf-next 1/5] bpf: udp: Use bpf_udp_iter_batch_item for bpf_udp_iter_state batch items Jordan Rife
2025-04-11 17:35 ` [PATCH v2 bpf-next 2/5] bpf: udp: Propagate ENOMEM up from bpf_iter_udp_batch Jordan Rife
2025-04-11 22:10 ` Martin KaFai Lau
2025-04-11 23:31 ` Jordan Rife
2025-04-12 3:47 ` Martin KaFai Lau
2025-04-14 0:02 ` Jordan Rife
2025-04-14 21:54 ` Martin KaFai Lau
2025-04-14 23:59 ` Jordan Rife
2025-04-11 17:35 ` [PATCH v2 bpf-next 3/5] bpf: udp: Avoid socket skips and repeats during iteration Jordan Rife
2025-04-11 20:12 ` Kuniyuki Iwashima
2025-04-11 17:35 ` [PATCH v2 bpf-next 4/5] selftests/bpf: Return socket cookies from sock_iter_batch progs Jordan Rife
2025-04-11 17:35 ` [PATCH v2 bpf-next 5/5] selftests/bpf: Add tests for bucket resume logic in UDP socket iterators Jordan Rife
2025-04-11 22:32 ` Martin KaFai Lau
2025-04-15 0:04 ` Jordan Rife [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_2igISGVwL9yqM-@t14 \
--to=jordan@jrife.io \
--cc=aditi.ghag@isovalent.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kuniyu@amazon.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.