From: Mike Rapoport <rppt@kernel.org>
To: Donet Tom <donettom@linux.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Ritesh Harjani <ritesh.list@gmail.com>,
rafael@kernel.org, Danilo Krummrich <dakr@kernel.org>
Subject: Re: [PATCH 2/2] base/node: Use curr_node_memblock_intersect_memory_block to Get Memory Block NID if CONFIG_DEFERRED_STRUCT_PAGE_INIT is Set
Date: Tue, 15 Apr 2025 12:46:39 +0300 [thread overview]
Message-ID: <Z_4q_1TEJgcvlUlr@kernel.org> (raw)
In-Reply-To: <736ca451-8adc-4c5c-b721-6b78eaeb4699@linux.ibm.com>
On Fri, Apr 11, 2025 at 05:06:55PM +0530, Donet Tom wrote:
> On 4/11/25 4:29 PM, Mike Rapoport wrote:
> >
> > It might make sense to use for_each_mem_range() as top level loop in
> > node_dev_init(), but that's a separate topic.
>
> Yes, this makes sense to me as well. So in your opinion, instead of adding
> a new memblock search function like I added , it's better to use
> |for_each_mem_range()| in|node_dev_init()|, which would work for all
> cases—regardless of whether|CONFIG_DEFERRED_STRUCT_PAGE_INIT| is set or
> not. Right?
Yes
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2025-04-15 9:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 5:27 [PATCH 1/2] mm/memblock: Added a New Memblock Function to Check if the Current Node's Memblock Region Intersects with a Memory Block Donet Tom
2025-04-09 5:27 ` [PATCH 2/2] base/node: Use curr_node_memblock_intersect_memory_block to Get Memory Block NID if CONFIG_DEFERRED_STRUCT_PAGE_INIT is Set Donet Tom
2025-04-10 8:07 ` Mike Rapoport
2025-04-10 18:57 ` Donet Tom
2025-04-11 10:59 ` Mike Rapoport
2025-04-11 11:36 ` Donet Tom
2025-04-15 9:46 ` Mike Rapoport [this message]
2025-04-15 10:08 ` Donet Tom
2025-04-10 2:20 ` [PATCH 1/2] mm/memblock: Added a New Memblock Function to Check if the Current Node's Memblock Region Intersects with a Memory Block Andrew Morton
2025-04-10 4:35 ` Donet Tom
2025-04-10 7:03 ` kernel test robot
2025-04-10 7:25 ` kernel test robot
2025-04-10 7:49 ` Mike Rapoport
2025-04-10 19:06 ` Donet Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_4q_1TEJgcvlUlr@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dakr@kernel.org \
--cc=david@redhat.com \
--cc=donettom@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rafael@kernel.org \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.