From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v6 4/4] ci: apply patchwork series in ci-docker-build workflow
Date: Tue, 15 Apr 2025 18:34:52 +0200 [thread overview]
Message-ID: <Z_6KrACqq3DUs_ty@yuki.lan> (raw)
In-Reply-To: <20250415-patchwork_ci-v6-4-81e6d4184af5@suse.com>
Hi!
> + - name: Apply Patchwork series
> + if: inputs.SERIES_ID != '' && inputs.SERIES_MBOX != ''
> + env:
> + PATCHWORK_TOKEN: ${{ secrets.PATCHWORK_TOKEN }}
> + run: |
> + git config --global user.name 'GitHub CI'
> + git config --global user.email 'github@example.com'
> + git config --global --add safe.directory "$GITHUB_WORKSPACE"
> +
> + git checkout -b review_patch_series_"${{ inputs.SERIES_ID }}"
So we create a branch for each CI run but I do not see any place where
we get rid of it. Shouldn't we remove it after the CI run?
> + curl -k "${{ inputs.SERIES_MBOX }}" | git am
> +
> + ./ci/tools/patchwork.sh state "${{ inputs.SERIES_ID }}" "needs-review-ack"
> +
> - name: ver_linux
> run: ./ver_linux
>
> @@ -158,3 +184,14 @@ jobs:
> run: |
> if [ "$MAKE_INSTALL" = 1 ]; then INSTALL_OPT="-i"; fi
> ./build.sh -r install -o ${TREE:-in} $INSTALL_OPT
> +
> + - name: Send results to Patchwork
> + if: always() && inputs.SERIES_ID != '' && inputs.SERIES_MBOX != ''
> + env:
> + PATCHWORK_TOKEN: ${{ secrets.PATCHWORK_TOKEN }}
> + run: |
> + ./ci/tools/patchwork.sh check \
> + "${{ inputs.SERIES_ID }}" \
> + "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" \
> + "${{ matrix.container }}" \
> + "${{ job.status }}"
The rest looks good, once the branch deletion is clarified or fixed:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-04-15 16:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 10:00 [LTP] [PATCH v6 0/4] Support for Patchwork CI Andrea Cervesato
2025-04-15 10:00 ` [LTP] [PATCH v6 1/4] ci: install dependences for patchwork-ci script Andrea Cervesato
2025-04-15 14:45 ` Cyril Hrubis
2025-04-15 10:00 ` [LTP] [PATCH v6 2/4] ci: add patchwork communication script Andrea Cervesato
2025-04-15 13:48 ` pvorel
2025-04-15 15:36 ` Cyril Hrubis
2025-04-15 10:00 ` [LTP] [PATCH v6 3/4] ci: add ci-patchwork-trigger workflow Andrea Cervesato
2025-04-15 13:53 ` pvorel
2025-04-15 15:12 ` Cyril Hrubis
2025-04-15 16:10 ` Andrea Cervesato via ltp
2025-04-15 10:00 ` [LTP] [PATCH v6 4/4] ci: apply patchwork series in ci-docker-build workflow Andrea Cervesato
2025-04-15 13:55 ` pvorel
2025-04-15 16:34 ` Cyril Hrubis [this message]
2025-04-15 16:37 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_6KrACqq3DUs_ty@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.