From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Andrey Albershteyn <aalbersh@redhat.com>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] mkfs: fix blkid probe API violations causing weird output
Date: Tue, 15 Apr 2025 22:12:17 -0700 [thread overview]
Message-ID: <Z_88MWlTrrdIB03Y@infradead.org> (raw)
In-Reply-To: <20250416045044.GA25700@frogsfrogsfrogs>
On Tue, Apr 15, 2025 at 09:50:44PM -0700, Darrick J. Wong wrote:
> static int probe_apfs(blkid_probe pr, const struct blkid_idmag *mag)
> {
> struct apfs_super_block *sb;
>
> sb = blkid_probe_get_sb(pr, mag, struct apfs_super_block);
> if (!sb)
> return errno ? -errno : BLKID_PROBE_NONE;
>
> So I guess it's just ... super broken?
Heh. Please just send this report to the util-linux list.
prev parent reply other threads:[~2025-04-16 5:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 1:28 [PATCH] mkfs: fix blkid probe API violations causing weird output Darrick J. Wong
2025-04-16 4:35 ` Christoph Hellwig
2025-04-16 4:50 ` Darrick J. Wong
2025-04-16 5:12 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_88MWlTrrdIB03Y@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.