From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63BBB211460; Mon, 7 Apr 2025 08:50:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744015838; cv=none; b=Lat6+9pqPW1Q6fXxgUvDPRmjydOp6OTPtY2pbSH5Em5AfNQY+E0w2W3RGjwB5crQD49pwl9Twxi2rXTDCr50TLmdpD1z+115ITuparLuugsRBlI4k6e615uBE797SSg2hCx3lLgRLpgqcSXSuyD35xMKfAGZ5g7jwvcxWHliVL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744015838; c=relaxed/simple; bh=Pzt5wycJlkf+e9wpxWW1NN9vBkIs1eaZ3Ka2d8Lwj+M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IKiQucZ431mNMCU//rDNeDB5jh5sEFAOlEGL9hS4UQ0bjj7n7oJbZ7sxo+yJRNmow3FaBcpgbQ0b3hDvpHinHj9bPq3+otIF2w8oFQzQjSevvb7DH9dYSCDcEx0CWIam4v/cD1BZGidJa/YEfrRvDjy1AZwuyMEUo+EKM/jpj0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: PA7LLTc+TQK9RqUDehrywQ== X-CSE-MsgGUID: kTOCl/7DSwu+YYzC4Flc2w== X-IronPort-AV: E=McAfee;i="6700,10204,11396"; a="45278748" X-IronPort-AV: E=Sophos;i="6.15,193,1739865600"; d="scan'208";a="45278748" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2025 01:50:34 -0700 X-CSE-ConnectionGUID: 54jyaMuLQaiFeBAgQfsjog== X-CSE-MsgGUID: 02H2fUevQ/ioepiy0FFQaQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,193,1739865600"; d="scan'208";a="132739344" Received: from smile.fi.intel.com ([10.237.72.58]) by orviesa003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2025 01:50:31 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1u1iBY-0000000A0Zw-2oac; Mon, 07 Apr 2025 11:50:28 +0300 Date: Mon, 7 Apr 2025 11:50:28 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Orson Zhai , Baolin Wang , Chunyan Zhang , Peter Tyser , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 01/12] gpio: dln2: use new line value setter callbacks Message-ID: References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> <20250407-gpiochip-set-rv-gpio-part1-v1-1-78399683ca38@linaro.org> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-1-78399683ca38@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Apr 07, 2025 at 09:13:10AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > struct gpio_chip now has callbacks for setting line values that return > an integer, allowing to indicate failures. Convert the driver to using > them. ... > -static void dln2_gpio_set(struct gpio_chip *chip, unsigned offset, int value) > +static int dln2_gpio_set(struct gpio_chip *chip, unsigned int offset, > + int value) It gets even shorter. If you are fan of 80 characters from last decade, it still fits. -- With Best Regards, Andy Shevchenko