Re: [PATCH v2 05/20] iio: introduced iio_push_to_buffers_with_ts() that takes a data_total_len argument.

[Andy Shevchenko <andy@kernel.org>]

On Sun, Apr 06, 2025 at 06:19:46PM +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Check that data_total_len argument against iio_dev->scan_bytes.
> 
> The size needs to be at least as big as the scan. It can be larger,
> which is typical if only part of fixed sized storage is used due to
> a subset of channels being enabled.

...

> +static inline int iio_push_to_buffers_with_ts(struct iio_dev *indio_dev,
> +					      void *data, size_t data_total_len,
> +					      int64_t timestamp)

Do we still need to inherit int64_t type? Can't it be s64 instead?

> +{
> +	if (unlikely(data_total_len < indio_dev->scan_bytes)) {

> +		dev_err(&indio_dev->dev,
> +			"Undersized storage pushed to buffer\n");

One line, even for the fanatics of 80.

> +		return -ENOSPC;
> +	}
> +
> +	return iio_push_to_buffers_with_timestamp(indio_dev, data, timestamp);
> +}

-- 
With Best Regards,
Andy Shevchenko