From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
Waiman Long <longman@redhat.com>,
Carlos Llamas <cmllamas@google.com>,
Ying Huang <huang.ying.caritas@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lockdep: change 'static const' variables to enum values
Date: Mon, 7 Apr 2025 13:42:28 +0300 [thread overview]
Message-ID: <Z_OsFKc1PTom_VO3@black.fi.intel.com> (raw)
In-Reply-To: <20250225200830.4031742-1-arnd@kernel.org>
On Tue, Feb 25, 2025 at 09:08:26PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> gcc warns about 'static const' variables even in headers when building
> with -Wunused-const-variables enabled:
>
> In file included from kernel/locking/lockdep_proc.c:25:
> kernel/locking/lockdep_internals.h:69:28: error: 'LOCKF_USED_IN_IRQ_READ' defined but not used [-Werror=unused-const-variable=]
> 69 | static const unsigned long LOCKF_USED_IN_IRQ_READ =
> | ^~~~~~~~~~~~~~~~~~~~~~
> kernel/locking/lockdep_internals.h:63:28: error: 'LOCKF_ENABLED_IRQ_READ' defined but not used [-Werror=unused-const-variable=]
> 63 | static const unsigned long LOCKF_ENABLED_IRQ_READ =
> | ^~~~~~~~~~~~~~~~~~~~~~
> kernel/locking/lockdep_internals.h:57:28: error: 'LOCKF_USED_IN_IRQ' defined but not used [-Werror=unused-const-variable=]
> 57 | static const unsigned long LOCKF_USED_IN_IRQ =
> | ^~~~~~~~~~~~~~~~~
> kernel/locking/lockdep_internals.h:51:28: error: 'LOCKF_ENABLED_IRQ' defined but not used [-Werror=unused-const-variable=]
> 51 | static const unsigned long LOCKF_ENABLED_IRQ =
> | ^~~~~~~~~~~~~~~~~
>
> This one is easy to avoid by changing the generated constant definition
> into an equivalent enum.
Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-04-07 10:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 20:08 [PATCH] lockdep: change 'static const' variables to enum values Arnd Bergmann
2025-04-07 10:42 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_OsFKc1PTom_VO3@black.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=cmllamas@google.com \
--cc=huang.ying.caritas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.