From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDFA0C36010 for ; Mon, 7 Apr 2025 17:15:46 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.940721.1340384 (Exim 4.92) (envelope-from ) id 1u1q4R-00055Z-Gg; Mon, 07 Apr 2025 17:15:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 940721.1340384; Mon, 07 Apr 2025 17:15:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1u1q4R-00055S-DG; Mon, 07 Apr 2025 17:15:39 +0000 Received: by outflank-mailman (input) for mailman id 940721; Mon, 07 Apr 2025 17:15:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1u1q4P-0004cn-RU for xen-devel@lists.xenproject.org; Mon, 07 Apr 2025 17:15:37 +0000 Received: from fout-a3-smtp.messagingengine.com (fout-a3-smtp.messagingengine.com [103.168.172.146]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb95c3e3-13d3-11f0-9eaa-5ba50f476ded; Mon, 07 Apr 2025 19:15:36 +0200 (CEST) Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 97D3B1380213; Mon, 7 Apr 2025 13:15:35 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Mon, 07 Apr 2025 13:15:35 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Apr 2025 13:15:33 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb95c3e3-13d3-11f0-9eaa-5ba50f476ded DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1744046135; x=1744132535; bh=qj8TCDCpmlYdT7b3QX/qcCPXxmCBlt/tr41GIjIAxv4=; b= b1mgqCGNWhkysWvvOkdoW/27KO2WLVSjCdsRo+duhN2kuZBh/ZQTc4Mige3HuP6B QAbmzTizBbhaoqC02NA4lKdJPS8LSaOz/4SkRxLYWvbUWchDHnM1KpjjU5V5itR/ Fb7wmIJVISeT1N3dzi6FD8+JiVaQuQsQtszOYNhRVLi4ERSFFHWt4K8ioZrRzKaW BcFcRHOZfiHxv/gv+xpI6vlGik/YbpsjH04ULZeaSAOjOmyzLLkWotrPB9JREKes cedkxQOE9S68GN4tLloOEuzESLpQGjWg3/GH4V4Uxqq0WNFLhVWBcqkvmJNFptDx ylUlbsCCRoAuHpyhzvi6JA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1744046135; x=1744132535; bh=qj8TCDCpmlYdT7b3QX/qcCPXxmCBlt/tr41 GIjIAxv4=; b=HrEfC4pGwmGc5tQUv39mp0dKANDigaAn3vLO6MhgLC951M+P3Im 41cejfUrQ1Je8iE4k/LRqvjDLCLngEOpYAFNLu5jGAOHBK/s7XmZ1QqU60K88OjG jnfn8TnK8r/dCbRaXs6TI1ewrwIzXCcvM/QbqMyCB95QlIqblgRWqbzpMB0zq4xl XOHtbAmQ2jN8FjgzcyxDAumcdUfqGeHLVXdmzxKCPiKuJgtP4PQy3i4a9R4Jio0/ miAQaI/m8DsGO+P4QYqksvcnBoarpeoAwmRzBH2YlG0IEBHph/wFO3meHYQdjXSx 9L0vY6W8eBxeV2EBcerX8MJAuC32N96sdtw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvtddtjeejucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt jeenucfhrhhomhepofgrrhgvkhcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuc eomhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecu ggftrfgrthhtvghrnhepgfduleetfeevhfefheeiteeliefhjefhleduveetteekveettd dvgeeuteefjedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh dpnhgspghrtghpthhtohepkedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheprghn ughrvgifrdgtohhophgvrhefsegtihhtrhhigidrtghomhdprhgtphhtthhopeigvghnqd guvghvvghlsehlihhsthhsrdigvghnphhrohhjvggtthdrohhrghdprhgtphhtthhopehs shhtrggsvghllhhinhhisehkvghrnhgvlhdrohhrghdprhgtphhtthhopegrnhhthhhonh ihrdhpvghrrghrugesvhgrthgvshdrthgvtghhpdhrtghpthhtohepmhhitghhrghlrdho rhiivghlsegrmhgurdgtohhmpdhrtghpthhtohepjhgsvghulhhitghhsehsuhhsvgdrtg homhdprhgtphhtthhopehjuhhlihgvnhesgigvnhdrohhrghdprhgtphhtthhopehrohhg vghrrdhprghusegtihhtrhhigidrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 7 Apr 2025 19:15:31 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH test-artifacts v2 14/12] scripts: build initrd cpio Message-ID: References: <20250407123448.1520451-2-marmarek@invisiblethingslab.com> <16f91d01-ea1c-43ec-a5d8-a55bb84fe94b@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FSG6cy5SZ83uMMP7" Content-Disposition: inline In-Reply-To: <16f91d01-ea1c-43ec-a5d8-a55bb84fe94b@citrix.com> --FSG6cy5SZ83uMMP7 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 7 Apr 2025 19:15:31 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH test-artifacts v2 14/12] scripts: build initrd cpio On Mon, Apr 07, 2025 at 06:11:29PM +0100, Andrew Cooper wrote: > On 07/04/2025 1:31 pm, Marek Marczykowski-G=C3=B3recki wrote: > > Build initrd format directly digestable by the kernel. Additionally, > > include it itself inside as boot/initrd-domU file, for domU booting in > > tests. > > This should avoid the need to repack tar -> cpio as part of the test > > job. > > > > Keep generating initrd.tar.gz as that's still used by older branches. > > > > Signed-off-by: Marek Marczykowski-G=C3=B3recki > > --- > > scripts/x86_64-rootfs-alpine.sh | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/scripts/x86_64-rootfs-alpine.sh b/scripts/x86_64-rootfs-al= pine.sh > > index b70b3a5..13e85fa 100755 > > --- a/scripts/x86_64-rootfs-alpine.sh > > +++ b/scripts/x86_64-rootfs-alpine.sh > > @@ -58,3 +58,8 @@ passwd -d "root" root > > cd / > > tar cvzf "${WORKDIR}/binaries/initrd.tar.gz" \ > > bin dev etc home init lib mnt opt root sbin usr var > > +mkdir boot > > +find bin dev etc home init lib mnt opt root sbin usr var |\ > > + cpio -o -H newc | gzip > boot/initrd-domU > > +find bin boot dev etc home init lib mnt opt root sbin usr var |\ > > + cpio -o -H newc | gzip > "${WORKDIR}/binaries/initrd.cpio.gz" \ >=20 > So, after looking at this a bit more, a few notes. >=20 > Trailing \ needs dropping. >=20 > initrd-domU probably ought to be named initrd-domU-base.cpio.gz so it's > clear what it is.=C2=A0 These are easy to fix up. Technically, it's useful as is already if you just want to check if domU starts. > Looking through the current initrd.tar.gz, we've got: >=20 > $ ls -lah ./var/cache/apk/ > total 1.9M > drwxr-xr-x 2 andrew andrew 4.0K Nov=C2=A0 8 15:12 . > drwxr-xr-x 4 andrew andrew 4.0K Sep=C2=A0 6=C2=A0 2024 .. > -rw-r--r-- 1 andrew andrew 425K Nov=C2=A0 8 15:12 APKINDEX.73fc500b.tar.gz > -rw-r--r-- 1 andrew andrew 1.4M Nov=C2=A0 8 15:12 APKINDEX.eb46142e.tar.gz >=20 > which (alone) is 5% of the size of the initrd.=C2=A0 I'll submit a patch > separately to drop this. Makes sense. > But doesn't this result in initrd.tar.gz being included in initrd-domU, > and then (doubly) in initrd.cpio.gz ? No, find (same as tar earlier) has explicit list of dirs to look at, which don't include initrd.* nor "binaries". --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --FSG6cy5SZ83uMMP7 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmf0CDMACgkQ24/THMrX 1ywQvQf/Wtly33pfYqMHyWh0TH11N9OEKp3BjUf+95E8fuf2bJhk1j9KHQ3VQAsq taWwWmH6WGaTH4xJrt+BPhoQMml7tOP630YR5k5I588HfJi8z6fAeG6xmoSxEile Fo4fisF7Vh5uGuPoGnFjHhEyA064EaEBEV2xoDSyxMYVUc1H2rzDqbE6cDk9EgSU xrnegIfiN8NUUmDYmfhbBSYL8v6KOM3TlykHHzCg4y7sW8OD/B3hPmufYFJ4uekl +G5iPJDgNrvtMdAJVdOgO91PLXxCmbHvHFfbM7QLDn7broM/Vm5MwYybb3QzboB1 YO5SaUE6eHv+M1gDCQuTves++TF42A== =W10d -----END PGP SIGNATURE----- --FSG6cy5SZ83uMMP7--