From: Moon Yeounsu <yyyynoom@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6] net: dlink: add support for reporting stats via `ethtool -S` and `ip -s -s link show`
Date: Tue, 8 Apr 2025 07:57:55 +0900 [thread overview]
Message-ID: <Z_RYc2R_Qf0xCaLv@mythos-cloud> (raw)
In-Reply-To: <86ac7c66-66da-458f-960a-3b27ba5e893f@lunn.ch>
On Mon, Apr 07, 2025 at 10:48:01PM +0200, Andrew Lunn wrote:
> When i see a list like this, it makes me think this should be broken
> up into multiple patches. Ideally you want lots of simple patches
> which are obviously correct.
Would it be appropriate to split this into a patchset, then?
To be honest, this is my first time creating a patchset, so
I'm not entirely sure how to divide it properly.
For now, I'm thinking of splitting it as follows:
1. stat definitions and declarations
2. preprocessor directives (`#ifdef`)
3. `spin_[un]lock_irq()` related changes
4. `get_stats()` implementation
5. `ethtool_ops` implementation
Is it okay to resend the v7 patchset split as above?
next prev parent reply other threads:[~2025-04-07 22:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 13:49 [PATCH net-next v6] net: dlink: add support for reporting stats via `ethtool -S` and `ip -s -s link show` Moon Yeounsu
2025-04-07 20:43 ` Andrew Lunn
2025-04-07 22:12 ` Moon Yeounsu
2025-04-08 12:31 ` Andrew Lunn
2025-04-07 20:48 ` Andrew Lunn
2025-04-07 22:57 ` Moon Yeounsu [this message]
2025-04-08 12:37 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_RYc2R_Qf0xCaLv@mythos-cloud \
--to=yyyynoom@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.