From: Joe Damato <jdamato@fastly.com>
To: Michal Luczaj <mhal@rbox.co>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: Drop unused @sk of __skb_try_recv_from_queue()
Date: Mon, 7 Apr 2025 19:10:04 -0700 [thread overview]
Message-ID: <Z_SFfAGYrvDPl5DM@LQ3V64L9R2> (raw)
In-Reply-To: <20250407-cleanup-drop-param-sk-v1-1-cd076979afac@rbox.co>
On Mon, Apr 07, 2025 at 09:01:02PM +0200, Michal Luczaj wrote:
> __skb_try_recv_from_queue() deals with a queue, @sk is never used.
> Remove sk from function parameters, adapt callers.
>
> No functional change intended.
>
> Signed-off-by: Michal Luczaj <mhal@rbox.co>
> ---
> include/linux/skbuff.h | 3 +--
> net/core/datagram.c | 5 ++---
> net/ipv4/udp.c | 8 ++++----
> 3 files changed, 7 insertions(+), 9 deletions(-)
Reviewed-by: Joe Damato <jdamato@fastly.com>
next prev parent reply other threads:[~2025-04-08 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 19:01 [PATCH net-next] net: Drop unused @sk of __skb_try_recv_from_queue() Michal Luczaj
2025-04-08 2:10 ` Joe Damato [this message]
2025-04-09 2:40 ` patchwork-bot+netdevbpf
2025-06-15 21:19 ` Michal Luczaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_SFfAGYrvDPl5DM@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.