From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Stefano Brivio <sbrivio@redhat.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v3 nf 3/3] nft_set_pipapo: add avx register usage tracking for NET_DEBUG builds
Date: Tue, 8 Apr 2025 13:41:14 +0200 [thread overview]
Message-ID: <Z_ULWpqOzR1mdt7C@calendula> (raw)
In-Reply-To: <20250408095508.GA536@breakpoint.cc>
On Tue, Apr 08, 2025 at 11:55:08AM +0200, Florian Westphal wrote:
> Stefano Brivio <sbrivio@redhat.com> wrote:
> > I wonder, by the way, if 1/3 and 2/3 shouldn't be applied meanwhile
> > (perhaps that was the reason for moving this at the end...?).
>
> Yes, that was one of the reasons.
>
> Pablo, I will resend this patch later, targeting nf-next.
> I will not resend patches 1 and 2.
OK; then patch 1 and 2 for nf.git and 3 for nf-next.git.
> > Otherwise it's a bit difficult (for me at least) to understand how this
> > macro should be used (without following the whole path). Alternatively,
> > a comment could also fix that I guess.
>
> I prefer better variable name to comments.
>
> > Everything else looks good to me, thanks for all the improvements!
>
> Thanks for reviewing. I will wait for patches 1 and 2
> to make it to nf, then for nf->nf-next resync and will
> then resend this with all of your change requests included.
OK.
prev parent reply other threads:[~2025-04-08 11:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 17:40 [PATCH v3 nf 0/3] nft_set_pipapo: fix incorrect avx2 match of 5th field octet Florian Westphal
2025-04-07 17:40 ` [PATCH v3 nf 1/3] " Florian Westphal
2025-04-07 17:40 ` [PATCH v3 nf 2/3] selftests: netfilter: add test case for recent mismatch bug Florian Westphal
2025-04-07 17:40 ` [PATCH v3 nf 3/3] nft_set_pipapo: add avx register usage tracking for NET_DEBUG builds Florian Westphal
2025-04-08 7:29 ` Stefano Brivio
2025-04-08 9:55 ` Florian Westphal
2025-04-08 11:41 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_ULWpqOzR1mdt7C@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.