From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Michal Kubiak <michal.kubiak@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] net: airoha: Add l2_flows rhashtable
Date: Wed, 9 Apr 2025 00:54:48 +0200 [thread overview]
Message-ID: <Z_WpOIGugyLnc99N@lore-desk> (raw)
In-Reply-To: <20250408115727.6b7468b3@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
> On Tue, 8 Apr 2025 18:49:40 +0200 Lorenzo Bianconi wrote:
> > > I didn't find any usage of L4 flow type in the series.
> > > Is that reserved for future series? Shouldn't it be added together with
> > > its usage then?
> >
> > FLOW_TYPE_L4 is equal to 0 so it is the default value for
> > airoha_flow_table_entry type when not set explicitly.
> > It is done this way to reduce code changes.
>
> That seems quite unintuitive. Could you init explicitly for the
> benefit of people reading this code?
ack, I will do in v2.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-04-08 22:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 14:18 [PATCH net-next 0/3] Add L2 hw acceleration for airoha_eth driver Lorenzo Bianconi
2025-04-07 14:18 ` [PATCH net-next 1/3] net: airoha: Add l2_flows rhashtable Lorenzo Bianconi
2025-04-08 15:36 ` Michal Kubiak
2025-04-08 16:49 ` Lorenzo Bianconi
2025-04-08 18:41 ` Michal Kubiak
2025-04-08 18:57 ` Jakub Kicinski
2025-04-08 22:54 ` Lorenzo Bianconi [this message]
2025-04-07 14:18 ` [PATCH net-next 2/3] net: airoha: Add airoha_ppe_foe_flow_remove_entry_locked() Lorenzo Bianconi
2025-04-08 20:12 ` Michal Kubiak
2025-04-08 23:23 ` Lorenzo Bianconi
2025-04-07 14:18 ` [PATCH net-next 3/3] net: airoha: Add L2 hw acceleration support Lorenzo Bianconi
2025-04-08 19:56 ` Michal Kubiak
2025-04-08 23:19 ` Lorenzo Bianconi
2025-04-08 18:52 ` [PATCH net-next 0/3] Add L2 hw acceleration for airoha_eth driver Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_WpOIGugyLnc99N@lore-desk \
--to=lorenzo@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.