From: Ingo Molnar <mingo@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v1 1/1] x86/early_printk: Use 'mmio32' for consistency
Date: Wed, 9 Apr 2025 12:23:13 +0200 [thread overview]
Message-ID: <Z_ZKkccUa9pVH09J@gmail.com> (raw)
In-Reply-To: <20250407172214.792745-1-andriy.shevchenko@linux.intel.com>
* Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> First of all, using 'mmio' prevents proper implementation of 8-bit accessors.
> Second, it's simply inconsistent with uart8250 set of options. Rename it to
> 'mmio32'. While at it, remove rather misleading comment in the documentation.
> From now on mmio32 is self-explanatory and pciserial supports not only 32-bit
> MMIO accessors.
>
> Fixes: 3181424aeac2 ("x86/early_printk: Add support for MMIO-based UARTs")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 5 +----
> arch/x86/kernel/early_printk.c | 6 +++---
> 2 files changed, 4 insertions(+), 7 deletions(-)
Thank you for taking care of this, I've queued these fixes in tip:x86/urgent.
Ingo
next prev parent reply other threads:[~2025-04-09 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 17:22 [PATCH v1 1/1] x86/early_printk: Use 'mmio32' for consistency Andy Shevchenko
2025-04-09 10:23 ` Ingo Molnar [this message]
2025-04-09 11:44 ` [tip: x86/urgent] x86/early_printk: Use 'mmio32' for consistency, fix comments tip-bot2 for Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2025-04-08 20:46 [PATCH v1 1/1] x86/early_printk: Use 'mmio32' for consistency dmkhn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_ZKkccUa9pVH09J@gmail.com \
--to=mingo@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.