From: Niklas Cassel <cassel@kernel.org>
To: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
nic_swsd@realtek.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] r8169: do not call rtl8169_down() twice on shutdown
Date: Wed, 16 Apr 2025 18:03:36 +0200 [thread overview]
Message-ID: <Z__U2O2xetryAK_E@ryzen> (raw)
In-Reply-To: <276986c2-7dbe-33e5-3c11-ba8b2b2083a2@oss.qualcomm.com>
Hello Krishna Chaitanya,
On Wed, Apr 16, 2025 at 09:15:19PM +0530, Krishna Chaitanya Chundru wrote:
> On 4/16/2025 7:43 PM, Niklas Cassel wrote:
> >
> > So perhaps we should hold off with this patch.
> >
> I disagree on this, it might be causing issue with net driver, but we
> might face some other issues as explained above if we don't call
> pci_stop_root_bus().
When I wrote hold off with this patch, I meant the patch in $subject,
not your patch.
When it comes to your patch, I think that the commit log needs to explain
why it is so special.
Because AFAICT, all other PCIe controller drivers call pci_stop_root_bus()
in the .remove() callback, not in the .shutdown() callback.
Doing things differently from all other PCIe controller drivers is usually
a red flag.
Kind regards,
Niklas
next prev parent reply other threads:[~2025-04-16 16:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 9:53 [PATCH] r8169: do not call rtl8169_down() twice on shutdown Niklas Cassel
2025-04-15 18:48 ` Heiner Kallweit
2025-04-16 14:13 ` Niklas Cassel
2025-04-16 15:45 ` Krishna Chaitanya Chundru
2025-04-16 16:03 ` Niklas Cassel [this message]
2025-04-16 17:15 ` Krishna Chaitanya Chundru
2025-04-18 17:19 ` Manivannan Sadhasivam
2025-04-18 21:52 ` Heiner Kallweit
2025-04-19 10:18 ` Heiner Kallweit
2025-04-19 23:18 ` Krishna Chaitanya Chundru
2025-04-20 6:25 ` Heiner Kallweit
2025-04-23 17:39 ` Bjorn Helgaas
2025-04-23 17:50 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z__U2O2xetryAK_E@ryzen \
--to=cassel@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=kuba@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.