From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Avri Altman <Avri.Altman@sandisk.com>,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] mmc: core: Further avoid re-storing power to the eMMC before a shutdown
Date: Wed, 9 Apr 2025 16:46:54 +0200 [thread overview]
Message-ID: <Z_aIXqdWh8n-4LKo@shikoro> (raw)
In-Reply-To: <CAPDyKFooWDpmfJoCFwjED_Utw6HppjAN5JjBL9vcZW1LsKeOFg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]
> I understand what you are saying and I agree. However, the problem is
> that your concern applies to a lot more code in the mmc core, but this
> condition.
We can easily agree on that :)
> Don't get me wrong, I don't mind useful comments and good
> documentation, but perhaps what we are really missing is a general mmc
> documentation that describes how the core is working and in particular
> the power-management part of it.
That would be the ideal solution, no doubt.
> Unfortunately, I don't think I will have the bandwidth currently to
> work on this.
Same here. Plus, I don't have a complete understanding of it. Obtaining
this understanding and then write some docs about my findings would be
awesome, of course. But -EBUSY, too...
> That said, I am going to apply the $subject patch as is - but feel
I still think that having the comment is better than not having it, but
I accept your decision and will still be happy that we finally solved
the power-off-notification issue \o/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-04-09 14:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 15:27 [PATCH v2 0/5] mmc: core: Add support for graceful host removal for eMMC/SD Ulf Hansson
2025-04-07 15:27 ` [PATCH v2 1/5] mmc: core: Convert mmc_can_poweroff_notify() into a bool Ulf Hansson
2025-04-07 15:27 ` [PATCH v2 2/5] mmc: core: Further avoid re-storing power to the eMMC before a shutdown Ulf Hansson
2025-04-08 8:09 ` Wolfram Sang
2025-04-08 12:40 ` Ulf Hansson
2025-04-08 15:07 ` Wolfram Sang
2025-04-09 13:13 ` Ulf Hansson
2025-04-09 14:46 ` Wolfram Sang [this message]
2025-04-07 15:27 ` [PATCH v2 3/5] mmc: core: Convert into an enum for the poweroff-type for eMMC Ulf Hansson
2025-04-07 15:27 ` [PATCH v2 4/5] mmc: core: Add support for graceful host removal " Ulf Hansson
2025-04-07 15:27 ` [PATCH v2 5/5] mmc: core: Add support for graceful host removal for SD Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_aIXqdWh8n-4LKo@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=Avri.Altman@sandisk.com \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.