Re: [perf top] annotation doesn't work, libunwind doesn't seem to be working either

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Wed, Apr 09, 2025 at 09:19:01AM -0300, Arnaldo Carvalho de Melo wrote:
> On Tue, Apr 08, 2025 at 11:23:54PM -0300, Arnaldo Carvalho de Melo wrote:
> > On Tue, Apr 08, 2025 at 10:05:15AM +0200, Ingo Molnar wrote:
> > >      - Yay! But very unintuitive. The intuitive step would have been 
> > >        the left arrow key BTW. (with restoring the cursor position to 
> > >        the cc1 entry I pressed 'Enter' on originally), but that doesn't 
>  
> > That is how I implemented it initially, yes, over 10 years ago.
> 
> I'll experiment with making the Left arrow key, if already on the first
> column, to work as zoom out.

Can you try this, on top of the series or even just this, pressing left
should do what we want.

diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
index 115aa1af5a0218cd..dc88427b4ae5af4c 100644
--- a/tools/perf/ui/browser.c
+++ b/tools/perf/ui/browser.c
@@ -459,6 +459,8 @@ int ui_browser__run(struct ui_browser *browser, int delay_secs)
 				goto out;
 			if (browser->horiz_scroll != 0)
 				--browser->horiz_scroll;
+			else
+				goto out;
 			break;
 		case K_PGDN:
 		case ' ':