From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DC6E2046BF for ; Thu, 10 Apr 2025 07:11:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269069; cv=none; b=CbXWwFCY2nbXJ/ruv1hjmhHsyVBqIN2ro1d/dvBKLIo3kEbkyVy6QVpAleo/h0Wlbg5OvcB4Zvl64Inbn7PRu3+otKbXU8GeeKZJv3PZcW+PeNzre7UO+9g7CFubvutLvmazgti5iHTy6De8YBfeopFv7OfY0WI18tHbOMbuq4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269069; c=relaxed/simple; bh=dvCmIESeU+0C8gMiKn7xzTjU+gOvecKI17trA15juLg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fOquWnhPZHuAT7q0TkLfIv26B2puZGFtNFyvKeL/K/AupIPQCDzr+UWsRdTrGLmyqFJOHag2y+Li6oFc47doCBcCqIThXqkLksGUUoEZe4GxOzk9yHXcvCnmRVL6f7wJAKdL0qaH7yWGZIiFV9LCvSQ3MeKu6awdf8/Sf4xrsbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ULDdCNlA; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ULDdCNlA" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-abbb12bea54so93047166b.0 for ; Thu, 10 Apr 2025 00:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744269064; x=1744873864; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3OcYzRuci4DVDvTV5wL2NFanwr7+BVH3bP+rdckE45M=; b=ULDdCNlA4TtZRmbNS/hhx1qBkP2bmoxiF2q3FKZdJakVYuo6cYyjYY4bIR1wxq99ER BPoIRXLkaZk7TxY2PfVTyJTNJdXWBkZwkECtuP+cu9/+XFDZpQhxhuxsfoBYPy6n4lcG Ys9mA65+mktLwmU8tBDeFf7Lgjsz3VO17Dqy1jnWie4PYvx+Szg7dBUryq6hAJPaHmKX A89JRthSvxOFHqYL9ezHQuYP6DM/n+zqmSIPPuuq4kA9qzEN0RCCZ4DBCI9yol/Tm8km 0ilUJcb/vUiXIxn7w8VklcIzWA1dvN70egK6euL+LBL/FYWl776f133TfjSgsCmVTYi1 47Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744269064; x=1744873864; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3OcYzRuci4DVDvTV5wL2NFanwr7+BVH3bP+rdckE45M=; b=laon2vzfk02DKd3s2scPCT7h5fOMJvhRdnERWNqSftdeWFQeqMlTtYSaZj/LBMPyTS aEV+aa3+/dIgydo3CJ9YyQiUUJl8pEpopCBXUxXfyGhHZcEg/lFDGCHsk1BKoL8QY91Q bQe+/1EIpuNZOZXjmwKido7hd7V+QvLp2OeCGXoX7Rngn3/TmSyvMeoskowtRp/m9ed7 pP3u6ITKKUCwuPMTGpXHGs2PUiyEp+wbnKAUtpHSe77V1tQSgjG/eUgv63K1kGt5b7GC fF8x2nbKEp3GREtorEXuuPMwsJ25MaI9X9Qqj6o5qg86RjPMhpaSzoOzFTvf4WD97HCA Z/Qw== X-Forwarded-Encrypted: i=1; AJvYcCW/esxh24+uaohzmBObjhiK89Ub4XGopsYD0pv7+DvO6U+VABWFDVSsXSkVzAliNPWtZb8=@lists.linux.dev X-Gm-Message-State: AOJu0YykTORrV+r7p65Z+GRZz9jZY/j4LT9lRbpdAEAwzaVdSt2VvOBs 0WnWKrnqA/H7A+TMzVjI1JR3m+Aj7flOcKZsnqdqXa7we4vZrdRXRiOAeZTrIMk= X-Gm-Gg: ASbGncukmTKRJ3G/3TRdjAVPulc7LwWCpgyFcZ0v5veIj0QHW2m+q/pVY2LlkSI0lLn jxYA9pjI1GCD2eWIwoEkcu6TyqO63t5Ufj1acfmYIC+6pTmlkok+yClA3LTNgO6OXVOnlIPjn0x ociO+8d/sn29DTen4uQgEP/DYxDzJ8m0S82eA7RyLXwpgPwg90esiTLua3f1ApjJOfHIxLhZLWW zK15ol02XI4/SBCgXKUa10GrIhfwrJ90isvBiYJw8reZb3O0AiuqQUrF1h9e1aNY9MMzD1jR3n9 JRsN/roj/fv3OFMxtgSZAFH2bqwKmzGXccBhCLrFUgad3Ya4CVQ= X-Google-Smtp-Source: AGHT+IETfspJRi9jQhAHy7G+NAIq/HN8GQhfewV/oWn/J+Tx4X7F7gfIyNI7Jkc9sjEejt3cHqWuJA== X-Received: by 2002:a17:907:da0:b0:aca:a1d7:a830 with SMTP id a640c23a62f3a-acabd185e69mr120878666b.13.1744269064280; Thu, 10 Apr 2025 00:11:04 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff21:ef30:ae8a:4fb8:9c71:6be]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1cb3fcdsm219989266b.107.2025.04.10.00.11.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 00:11:03 -0700 (PDT) Date: Thu, 10 Apr 2025 09:10:57 +0200 From: Stephan Gerhold To: Konrad Dybcio Cc: Ulf Hansson , "Rob Herring (Arm)" , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "Rafael J. Wysocki" , Viresh Kumar , Matthias Brugger , AngeloGioacchino Del Regno , Vincenzo Frascino , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Bjorn Andersson , Konrad Dybcio , Thomas Bogendoerfer , Viresh Kumar , Nishanth Menon , Stephen Boyd , zhouyanjie@wanyeetech.com, Conor Dooley , Nicolas Ferre , Claudiu Beznea , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Heiko Stuebner , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Geert Uytterhoeven , Magnus Damm , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Manivannan Sadhasivam Subject: Re: [PATCH 09/19] arm: dts: qcom: sdx55/sdx65: Fix CPU power-domain-names Message-ID: References: <20250403-dt-cpu-schema-v1-0-076be7171a85@kernel.org> <20250403-dt-cpu-schema-v1-9-076be7171a85@kernel.org> <03011a33-174b-4027-bdd2-043aa685380b@oss.qualcomm.com> <66f8d957-f7a5-4aec-b8e7-5bcc7ff7f569@oss.qualcomm.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66f8d957-f7a5-4aec-b8e7-5bcc7ff7f569@oss.qualcomm.com> On Wed, Apr 09, 2025 at 08:35:29PM +0200, Konrad Dybcio wrote: > On 4/7/25 6:27 PM, Ulf Hansson wrote: > > On Fri, 4 Apr 2025 at 22:41, Konrad Dybcio > > wrote: > >> > >> On 4/4/25 4:59 AM, Rob Herring (Arm) wrote: > >>> "rpmhpd" is not documented nor used anywhere. As the enable-method is > >>> "psci" use "psci" for the power-domain name. > >>> > >>> Signed-off-by: Rob Herring (Arm) > >>> --- > >> > >> "psci" is what we want here, but these platforms require some more > >> massaging.. > > > > So this isn't for CPU performance scaling? > > Nope! > Huh, this is definitely "perf" (= cpufreq) and not "psci" (= cpuidle). If you run blame on this line you get to: commit 0ec7bde7b590f8efa5823df3b52b32dd373060ff Author: Manivannan Sadhasivam Date: Thu Apr 8 22:34:45 2021 +0530 ARM: dts: qcom: sdx55: Add CPUFreq support Add CPUFreq support to SDX55 platform using the cpufreq-dt driver. There is no dedicated hardware block available on this platform to carry on the CPUFreq duties. Hence, it is accomplished using the CPU clock and regulators tied together by the operating points table. https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0ec7bde7b590f8efa5823df3b52b32dd373060ff The OPP table looks like it's supposed to set SDX55_CX performance states according to the chosen CPU frequency. MSM8909 has a similar setup where the CPU is supplied directly by VDDCX and we describe that with "perf" too [1]. What I don't understand is why the name "rpmhpd" does not appear in any driver. The MSM8909 setup goes via qcom-cpufreq-nvmem, where "perf" is directly assigned for cpufreq scaling. I can only think of two possible reasons: - The power domain is implicitly attached to the OPP table(?), because there is just a single power domain defined on the CPU, or - This was never working correctly. For both cases, I think it would be best to change the power domain name to "perf" like Uffe suggested. Thanks, Stephan [1]: https://lore.kernel.org/linux-pm/20231018-msm8909-cpufreq-v2-0-0962df95f654@kernkonzept.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 257E1C369A4 for ; Thu, 10 Apr 2025 07:53:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eUkZwVKmAPPwg9b9xUs8Xw+/FopA3CJjsIqI6pDisSY=; b=RXKKS7vKzSI6n6 kUQ5+vEgq5zM4DI2lhUa82LmY5XGJ5skhGzwkJCIsePeDoGs8mrD83gKhQi5b7LpAYAqap/JyRN9F Rf3Pcn+k2yOHnKiJA+77SBgp+2oDPzyJanRctUrnopc0jebo0o6Cyo2nJkBI0i/pdGPW/i8ck7lWQ 7mvuK1M6eZihBfrHuGWlY38YUIvwmQ1psdgyeRsKm04H9PvlaIQOT2bDIgAA285w897D/aJgICQME 7RkTOooRV9F7lzoosjjI7S4ZeSSJnML+t2RtEFlg9AR2fSqc4f3XcYimLepJ3PLb1NFxXC9azb92y 4Ra3ZGkihB8+P9e1I77A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2mid-00000009dCS-2iI3; Thu, 10 Apr 2025 07:53:03 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2m42-00000009UBl-2Jps for linux-amlogic@lists.infradead.org; Thu, 10 Apr 2025 07:11:09 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-ac289147833so94265266b.2 for ; Thu, 10 Apr 2025 00:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744269064; x=1744873864; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3OcYzRuci4DVDvTV5wL2NFanwr7+BVH3bP+rdckE45M=; b=yUs/O4dwK1DNXbpsQedSsErMEAN7SOtI0a8OqOXOE27FikQyIKhlT5d4gLKHT0jv8g gd0FnHwqeCJM3uZwlLzoXzvTXhoLa5wHnMMcKa3zjwkvIlcyMcE/6c4HnVbBtaANv9Iv p2JRdNmVeP8QXfq9q4A1gWLATNzuFmV56HPSS3BJiB5s9jR/UnF5n9OYy1mk5WA9XRov 9aNPYipgq+GSW4clzCpRR9NFyuDDN4nqgJuJ8Ivzo0GPoizF24hO7SnUQBCL0J1y3mbU wWreQZ4/SCTEKGhq20/+i91oRaxoa8ORn0QpK/0AkxeeXTe62a0LBJhVJOMqG2kbV+0n LLgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744269064; x=1744873864; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3OcYzRuci4DVDvTV5wL2NFanwr7+BVH3bP+rdckE45M=; b=dohVOyFI5KerxleJNjgBqk7KmQGs4ugIiKHkKfhMheGzbV6jHwTdAA7Vtcf392cLCa mbKzk+g07ze3W6ehoeE91f4bo0nde3c4cuZ3tRcOEFbVz3+ZI6n4JwAoriiH3zcYjtEF +TOrRjWamuZeoUGmnqVA82UCXjXHNij8eaS41AQsQgIjlhT28pEFeFilfkKpBICA9WZP 4+7BtjEC8qRWX/3jSOISgt4c4U/ih3qQbL8fQDmzTPnVUdK8G64FMkJ7/nxCZ8MQtm0Z JWE7rFI6b++C0yo3y5Cksumy/fnGnQuzBgdm56w0HDcvg9PP1DEgnJh6fDMS3OyaUxAL a0HA== X-Forwarded-Encrypted: i=1; AJvYcCVaCUb7KlkJ1PXvemH8KnEgOXjN3RYINHYMb8dl+KPtg2YzvFYguz4bsOWPxyP5O0+7yhrAXDIOz2hKMJ3A@lists.infradead.org X-Gm-Message-State: AOJu0YzdV/9bblal2NXYf1tz7anFH5NvDA2Ly4UH01+WwMlCnl1mFL/R yBMwHU4jv1ZpUc+ndHo/Ow1l8ZIkB9434nBWA49OpNb7UIFG34wA1Towh30ZSIY= X-Gm-Gg: ASbGncs6mUSLuoY6CfFYcH2QIFO3E7QcNXPfoEUMBBNy8MjG0rTRZ8tcOAy84ux3sWe 0wMXd2gbi/FRr1yifhmxzQBkC0Y2K+e/QWBgZoZ0rX8N+/U+jmGYmbkVaBdjJ/cPeu1FMqt8WKM yTElsc0lCkS1MctVdMWHv/0U5D1unHeyj+/zigKpfYsdqSqBff9cwlwwVOQyFHjf0eoVBRcWYO6 xoqD4p8/BvNRHEgcA2TCj9UyJ/UUlQlzdqe3ZOU+6LYL+KGcLo2oAlDasjira52Q3X7aU5gWhU1 22C2M8gyRZYdyqimlZzJ8L2xIMAN+AEhZsuo5E7Rl/61Y196iRA= X-Google-Smtp-Source: AGHT+IETfspJRi9jQhAHy7G+NAIq/HN8GQhfewV/oWn/J+Tx4X7F7gfIyNI7Jkc9sjEejt3cHqWuJA== X-Received: by 2002:a17:907:da0:b0:aca:a1d7:a830 with SMTP id a640c23a62f3a-acabd185e69mr120878666b.13.1744269064280; Thu, 10 Apr 2025 00:11:04 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff21:ef30:ae8a:4fb8:9c71:6be]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1cb3fcdsm219989266b.107.2025.04.10.00.11.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 00:11:03 -0700 (PDT) Date: Thu, 10 Apr 2025 09:10:57 +0200 From: Stephan Gerhold To: Konrad Dybcio Cc: Ulf Hansson , "Rob Herring (Arm)" , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "Rafael J. Wysocki" , Viresh Kumar , Matthias Brugger , AngeloGioacchino Del Regno , Vincenzo Frascino , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Bjorn Andersson , Konrad Dybcio , Thomas Bogendoerfer , Viresh Kumar , Nishanth Menon , Stephen Boyd , zhouyanjie@wanyeetech.com, Conor Dooley , Nicolas Ferre , Claudiu Beznea , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Heiko Stuebner , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Geert Uytterhoeven , Magnus Damm , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Manivannan Sadhasivam Subject: Re: [PATCH 09/19] arm: dts: qcom: sdx55/sdx65: Fix CPU power-domain-names Message-ID: References: <20250403-dt-cpu-schema-v1-0-076be7171a85@kernel.org> <20250403-dt-cpu-schema-v1-9-076be7171a85@kernel.org> <03011a33-174b-4027-bdd2-043aa685380b@oss.qualcomm.com> <66f8d957-f7a5-4aec-b8e7-5bcc7ff7f569@oss.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <66f8d957-f7a5-4aec-b8e7-5bcc7ff7f569@oss.qualcomm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250410_001106_726767_F41942F1 X-CRM114-Status: GOOD ( 21.50 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed, Apr 09, 2025 at 08:35:29PM +0200, Konrad Dybcio wrote: > On 4/7/25 6:27 PM, Ulf Hansson wrote: > > On Fri, 4 Apr 2025 at 22:41, Konrad Dybcio > > wrote: > >> > >> On 4/4/25 4:59 AM, Rob Herring (Arm) wrote: > >>> "rpmhpd" is not documented nor used anywhere. As the enable-method is > >>> "psci" use "psci" for the power-domain name. > >>> > >>> Signed-off-by: Rob Herring (Arm) > >>> --- > >> > >> "psci" is what we want here, but these platforms require some more > >> massaging.. > > > > So this isn't for CPU performance scaling? > > Nope! > Huh, this is definitely "perf" (= cpufreq) and not "psci" (= cpuidle). If you run blame on this line you get to: commit 0ec7bde7b590f8efa5823df3b52b32dd373060ff Author: Manivannan Sadhasivam Date: Thu Apr 8 22:34:45 2021 +0530 ARM: dts: qcom: sdx55: Add CPUFreq support Add CPUFreq support to SDX55 platform using the cpufreq-dt driver. There is no dedicated hardware block available on this platform to carry on the CPUFreq duties. Hence, it is accomplished using the CPU clock and regulators tied together by the operating points table. https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0ec7bde7b590f8efa5823df3b52b32dd373060ff The OPP table looks like it's supposed to set SDX55_CX performance states according to the chosen CPU frequency. MSM8909 has a similar setup where the CPU is supplied directly by VDDCX and we describe that with "perf" too [1]. What I don't understand is why the name "rpmhpd" does not appear in any driver. The MSM8909 setup goes via qcom-cpufreq-nvmem, where "perf" is directly assigned for cpufreq scaling. I can only think of two possible reasons: - The power domain is implicitly attached to the OPP table(?), because there is just a single power domain defined on the CPU, or - This was never working correctly. For both cases, I think it would be best to change the power domain name to "perf" like Uffe suggested. Thanks, Stephan [1]: https://lore.kernel.org/linux-pm/20231018-msm8909-cpufreq-v2-0-0962df95f654@kernkonzept.com/ _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2695C369A2 for ; Thu, 10 Apr 2025 07:53:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WW1M5fFVWEPWN/dDytZwIuSXdplXrGhYpN0HHyhziwA=; b=1w089DporTWmJD km59oLyPCqQqWBcSUxSzCAeFwRc3/jhOSP6PRsXA3CBSMdtMaRnrxeuBPwG+7qGhtUO/79JeI+fN7 88d0Dudd0EIC0pzFMxwpeAxxb5PUSmJ76kHQ3sEX+zrVfLkjQPFWqelgD33m0Yx3AzdGypttRapWu 67rGpfeE3mY0RAMtMzv+Vc10V28aodUr1/HFNwZY/6YffPF9GBK0KUT2ZfF65Kwm+FfLrOfIiLUOP oDI35wPummdtcmx75GeCzjS7E1UohFGPt5ticb5jEduILAMSVru/5ZLpX/ZzaVlKUAOVoel4KkLMX 2YmkDhK/ZNHIU+fmdqdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2mid-00000009dCM-1HRc; Thu, 10 Apr 2025 07:53:03 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2m42-00000009UBo-2KzG for linux-rockchip@lists.infradead.org; Thu, 10 Apr 2025 07:11:08 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5e6194e9d2cso938171a12.2 for ; Thu, 10 Apr 2025 00:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744269064; x=1744873864; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3OcYzRuci4DVDvTV5wL2NFanwr7+BVH3bP+rdckE45M=; b=yUs/O4dwK1DNXbpsQedSsErMEAN7SOtI0a8OqOXOE27FikQyIKhlT5d4gLKHT0jv8g gd0FnHwqeCJM3uZwlLzoXzvTXhoLa5wHnMMcKa3zjwkvIlcyMcE/6c4HnVbBtaANv9Iv p2JRdNmVeP8QXfq9q4A1gWLATNzuFmV56HPSS3BJiB5s9jR/UnF5n9OYy1mk5WA9XRov 9aNPYipgq+GSW4clzCpRR9NFyuDDN4nqgJuJ8Ivzo0GPoizF24hO7SnUQBCL0J1y3mbU wWreQZ4/SCTEKGhq20/+i91oRaxoa8ORn0QpK/0AkxeeXTe62a0LBJhVJOMqG2kbV+0n LLgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744269064; x=1744873864; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3OcYzRuci4DVDvTV5wL2NFanwr7+BVH3bP+rdckE45M=; b=EBXezZ3QV0jAT6SAmHwsJYCtE5ujFGEC/vP795dgAY19jGbdNOIKwz5eLLUYWNMHo7 9S4hVsbhgD5VdLbxhfvIjx4Olg1qzDhWm/MAIZ0maiaogqzA4vojGKOpmhXp+1nD9gwy 4hGrk+pwnaufs/Yvag4b4JyfM/49QAoVpHEGsrNgwEdx2kFWqWbmKNX4EQxjmhjDBdqi jo4zXAwqJgYIrrnzAihuFK5TACLKTOAtSN6tiJtulIp6N6a7IkJKD0Kcambe8gkzYggl 4++WbuHFnLy+RPG88dl5TNzgKO84FcsSbJ7FivermykPAzA8Dg2BNb6xC0PROlQ4dVKt RRKg== X-Forwarded-Encrypted: i=1; AJvYcCUZuR6A41MHrrd6s+mq3FSvZnT8AEKkypdVfxKfg9hLbPliXJbcMeavI4Bat3/WiPKr1jq+NYGh+4umDUcpag==@lists.infradead.org X-Gm-Message-State: AOJu0Yz4zCUxwXwNQ/xTpVJfIfillG9j30GlyxzUVxO2TpfsHB5vyisu hmNj0P9Q6x9vK8sWzqXPr2NlYwjObIQQSWvB2yb+2a0HQurWGkEpq9AfC3+FrEo= X-Gm-Gg: ASbGncvgGyZmJpGY34bKPAsVkCoX7HQ2x5r85CXg3d18deQJxJIXg9uEepUnZHaldCD pK85Gan9XiJuobOK3IxB0F3n6J7hKzTedkCGOMpWpFG1ULcarUjCztQAWQp4n/BN/fpOITYTRuo 3rehywnX5oitL9SDhO5Kyrjd+ShnDphYi8cp0+0oi04KBbFRQeNzcX3rXg0zoojKBAoJbezfWfX oXu2dmAC0NzTRej//iGc3vALiEC3PtPJLMAEbMm0+iKo+DI8E9wAcsAvly4WJ1vX3xYaz6THwHC ndkL8BP4v9HWGEkcbKtLNxIDv3H8VApIpmhrU9ugyLdm8+VjKnc= X-Google-Smtp-Source: AGHT+IETfspJRi9jQhAHy7G+NAIq/HN8GQhfewV/oWn/J+Tx4X7F7gfIyNI7Jkc9sjEejt3cHqWuJA== X-Received: by 2002:a17:907:da0:b0:aca:a1d7:a830 with SMTP id a640c23a62f3a-acabd185e69mr120878666b.13.1744269064280; Thu, 10 Apr 2025 00:11:04 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff21:ef30:ae8a:4fb8:9c71:6be]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1cb3fcdsm219989266b.107.2025.04.10.00.11.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 00:11:03 -0700 (PDT) Date: Thu, 10 Apr 2025 09:10:57 +0200 From: Stephan Gerhold To: Konrad Dybcio Cc: Ulf Hansson , "Rob Herring (Arm)" , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "Rafael J. Wysocki" , Viresh Kumar , Matthias Brugger , AngeloGioacchino Del Regno , Vincenzo Frascino , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Bjorn Andersson , Konrad Dybcio , Thomas Bogendoerfer , Viresh Kumar , Nishanth Menon , Stephen Boyd , zhouyanjie@wanyeetech.com, Conor Dooley , Nicolas Ferre , Claudiu Beznea , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Heiko Stuebner , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Geert Uytterhoeven , Magnus Damm , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Manivannan Sadhasivam Subject: Re: [PATCH 09/19] arm: dts: qcom: sdx55/sdx65: Fix CPU power-domain-names Message-ID: References: <20250403-dt-cpu-schema-v1-0-076be7171a85@kernel.org> <20250403-dt-cpu-schema-v1-9-076be7171a85@kernel.org> <03011a33-174b-4027-bdd2-043aa685380b@oss.qualcomm.com> <66f8d957-f7a5-4aec-b8e7-5bcc7ff7f569@oss.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <66f8d957-f7a5-4aec-b8e7-5bcc7ff7f569@oss.qualcomm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250410_001106_714318_CDA1D1C5 X-CRM114-Status: GOOD ( 21.71 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed, Apr 09, 2025 at 08:35:29PM +0200, Konrad Dybcio wrote: > On 4/7/25 6:27 PM, Ulf Hansson wrote: > > On Fri, 4 Apr 2025 at 22:41, Konrad Dybcio > > wrote: > >> > >> On 4/4/25 4:59 AM, Rob Herring (Arm) wrote: > >>> "rpmhpd" is not documented nor used anywhere. As the enable-method is > >>> "psci" use "psci" for the power-domain name. > >>> > >>> Signed-off-by: Rob Herring (Arm) > >>> --- > >> > >> "psci" is what we want here, but these platforms require some more > >> massaging.. > > > > So this isn't for CPU performance scaling? > > Nope! > Huh, this is definitely "perf" (= cpufreq) and not "psci" (= cpuidle). If you run blame on this line you get to: commit 0ec7bde7b590f8efa5823df3b52b32dd373060ff Author: Manivannan Sadhasivam Date: Thu Apr 8 22:34:45 2021 +0530 ARM: dts: qcom: sdx55: Add CPUFreq support Add CPUFreq support to SDX55 platform using the cpufreq-dt driver. There is no dedicated hardware block available on this platform to carry on the CPUFreq duties. Hence, it is accomplished using the CPU clock and regulators tied together by the operating points table. https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0ec7bde7b590f8efa5823df3b52b32dd373060ff The OPP table looks like it's supposed to set SDX55_CX performance states according to the chosen CPU frequency. MSM8909 has a similar setup where the CPU is supplied directly by VDDCX and we describe that with "perf" too [1]. What I don't understand is why the name "rpmhpd" does not appear in any driver. The MSM8909 setup goes via qcom-cpufreq-nvmem, where "perf" is directly assigned for cpufreq scaling. I can only think of two possible reasons: - The power domain is implicitly attached to the OPP table(?), because there is just a single power domain defined on the CPU, or - This was never working correctly. For both cases, I think it would be best to change the power domain name to "perf" like Uffe suggested. Thanks, Stephan [1]: https://lore.kernel.org/linux-pm/20231018-msm8909-cpufreq-v2-0-0962df95f654@kernkonzept.com/ _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip