From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org,
Davide Caratti <dcaratti@redhat.com>
Subject: Re: [PATCH net-next v2] net: airoha: Add matchall filter offload support
Date: Thu, 10 Apr 2025 09:16:37 +0200 [thread overview]
Message-ID: <Z_dwVVEWJp_VFBB4@lore-desk> (raw)
In-Reply-To: <20250409163737.2b6c13e3@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]
> On Wed, 09 Apr 2025 01:15:32 +0200 Lorenzo Bianconi wrote:
> > + airoha_fe_wr(eth, REG_PPE_DFT_CPORT0(0),
> > + FIELD_PREP(DFT_CPORT_MASK(7), FE_PSE_PORT_CDM1) |
> > + FIELD_PREP(DFT_CPORT_MASK(6), FE_PSE_PORT_CDM1) |
> > + FIELD_PREP(DFT_CPORT_MASK(5), FE_PSE_PORT_CDM1) |
> > + FIELD_PREP(DFT_CPORT_MASK(4), FE_PSE_PORT_CDM1) |
> > + FIELD_PREP(DFT_CPORT_MASK(4), FE_PSE_PORT_CDM1) |
>
> Coccicheck spotted that the previous line is duplicated..
>
> > + FIELD_PREP(DFT_CPORT_MASK(3), FE_PSE_PORT_CDM1) |
> > + FIELD_PREP(DFT_CPORT_MASK(2), FE_PSE_PORT_CDM1) |
> > + FIELD_PREP(DFT_CPORT_MASK(1), FE_PSE_PORT_CDM1) |
> > + FIELD_PREP(DFT_CPORT_MASK(0), FE_PSE_PORT_CDM1));
> > + airoha_fe_wr(eth, REG_PPE_DFT_CPORT0(1),
> > + FIELD_PREP(DFT_CPORT_MASK(7), FE_PSE_PORT_CDM2) |
> > + FIELD_PREP(DFT_CPORT_MASK(6), FE_PSE_PORT_CDM2) |
> > + FIELD_PREP(DFT_CPORT_MASK(5), FE_PSE_PORT_CDM2) |
> > + FIELD_PREP(DFT_CPORT_MASK(4), FE_PSE_PORT_CDM2) |
> > + FIELD_PREP(DFT_CPORT_MASK(4), FE_PSE_PORT_CDM2) |
>
> .. and here.
>
> > + FIELD_PREP(DFT_CPORT_MASK(3), FE_PSE_PORT_CDM2) |
> > + FIELD_PREP(DFT_CPORT_MASK(2), FE_PSE_PORT_CDM2) |
> > + FIELD_PREP(DFT_CPORT_MASK(1), FE_PSE_PORT_CDM2) |
> > + FIELD_PREP(DFT_CPORT_MASK(0), FE_PSE_PORT_CDM2));
> --
> pw-bot: cr
ack, I will fix them in v3.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2025-04-10 7:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 23:15 [PATCH net-next v2] net: airoha: Add matchall filter offload support Lorenzo Bianconi
2025-04-09 8:46 ` Davide Caratti
2025-04-09 23:37 ` Jakub Kicinski
2025-04-10 7:16 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_dwVVEWJp_VFBB4@lore-desk \
--to=lorenzo@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.