From: Christoph Hellwig <hch@infradead.org>
To: LongPing Wei <weilongping@oppo.com>
Cc: snitzer@kernel.org, mpatocka@redhat.com,
dm-devel@lists.linux.dev, guoweichao@oppo.com,
ebiggers@kernel.org, bvanassche@acm.org
Subject: Re: [PATCH 1/2] dm-bufio: improve the performance of __dm_bufio_prefetch
Date: Thu, 10 Apr 2025 01:29:55 -0700 [thread overview]
Message-ID: <Z_eBg4v5wzs7F7Wp@infradead.org> (raw)
In-Reply-To: <20250402070934.2387587-1-weilongping@oppo.com>
This commit message is extremtly sparse. Not helped by the fact that
the series also misses a cover letter.
On Wed, Apr 02, 2025 at 03:09:34PM +0800, LongPing Wei wrote:
> 1. call blk_flush_plug when cache hit as the address of the subsequent
> bio is no longer contiguous with the previous bio;
As you found out blk_flush_plug is not exported, and that for a good
reason. This also completely fails to explain why you want to do
this and what the measured benefit is.
> 2. skip cond_resched when ioprio class is rt;
Same here. Also these look compeltely unrelated and I have no idea
why they are in the same patch.
prev parent reply other threads:[~2025-04-10 8:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 7:09 [PATCH 1/2] dm-bufio: improve the performance of __dm_bufio_prefetch LongPing Wei
2025-04-02 7:09 ` [PATCH 2/2] dm-verity: prefetch all hash blocks in verity_ctr LongPing Wei
2025-04-02 9:56 ` Mikulas Patocka
2025-04-02 10:35 ` LongPing Wei
2025-04-02 18:44 ` Mikulas Patocka
2025-04-02 23:58 ` LongPing Wei
2025-04-10 8:28 ` Christoph Hellwig
2025-04-10 8:26 ` Christoph Hellwig
2025-04-02 17:43 ` [PATCH 1/2] dm-bufio: improve the performance of __dm_bufio_prefetch Eric Biggers
2025-04-03 0:12 ` LongPing Wei
2025-04-10 8:29 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_eBg4v5wzs7F7Wp@infradead.org \
--to=hch@infradead.org \
--cc=bvanassche@acm.org \
--cc=dm-devel@lists.linux.dev \
--cc=ebiggers@kernel.org \
--cc=guoweichao@oppo.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
--cc=weilongping@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.