Re: [PATCH 0/6] Qualcomm: cleanup OF_LIVE fixup and fix RB1/2

[Sumit Garg <sumit.garg@kernel.org>]

Hi Caleb,

On Wed, Apr 09, 2025 at 07:17:23PM +0200, Caleb Connolly wrote:
> Introduce a new event to signal that the live tree has been built,
> allowing boards to perform fixups on the tree before devices are bound.
> Crucially this allows for devices to be enabled or disabled, but also
> allows for properties that are parsed during the bind stage to be
> modified (such as dr_mode for dwc3).

Looks like a nice platform override available with OF_LIVE.

> 
> With this in place, mach-snapdragon is switched over to use the event
> and some hacky U-Boot specific DT overrides (which had to be undone
> prior to booting an image) are removed in favour of fixing up the
> livetree (which is not passed on to further boot stages).
>

Nice.

> Finally, some minor fixes are made for the QCM2290 RB1 board, the sdcard
> is enabled and it now uses USB host mode in U-Boot like it's bigger
> sibling the RB2.

FWIW, for the series:

Tested-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

> 
> ---
> Caleb Connolly (6):
>       event: signal when livetree has been built
>       mach-snapdragon: use EVT_OF_LIVE_INIT to apply DT fixups
>       mach-snapdragon: of_fixup: skip disabled USB nodes
>       clk/qcom: qcm2290: show clock name in set_rate()
>       mach-snapdragon: of_fixup: set dr_mode for RB1/2 boards
>       pinctrl: qcom: qcm2290: fix off by 1 in pin_count
> 
>  arch/arm/dts/qrb4210-rb2-u-boot.dtsi   |  6 -----
>  arch/arm/mach-snapdragon/board.c       |  1 -
>  arch/arm/mach-snapdragon/of_fixup.c    | 41 ++++++++++++++++++++--------------
>  arch/arm/mach-snapdragon/qcom-priv.h   | 14 ------------
>  common/event.c                         |  3 +++
>  drivers/clk/qcom/clock-qcm2290.c       |  2 +-
>  drivers/pinctrl/qcom/pinctrl-qcm2290.c |  2 +-
>  include/event.h                        |  9 ++++++++
>  lib/of_live.c                          |  3 +++
>  9 files changed, 41 insertions(+), 40 deletions(-)
> ---
> base-commit: e4ffc6a323586d700d88c73c319c25c740aedb49
> change-id: 20250409-livetree-fixup-0d7451cc3af3
> 
> Caleb Connolly <caleb.connolly@linaro.org>
>