All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: Gabriele Monaco <gmonaco@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, Waiman Long <longman@redhat.com>
Subject: Re: [PATCH] timers: Exclude isolated cpus from timer migation
Date: Thu, 10 Apr 2025 16:20:11 +0200	[thread overview]
Message-ID: <Z_fTmzdvLEmrAth6@localhost.localdomain> (raw)
In-Reply-To: <4fdc6582c828fbcd8c6ad202ed7ab560134d1fc3.camel@redhat.com>

Le Thu, Apr 10, 2025 at 03:56:02PM +0200, Gabriele Monaco a écrit :
> On Thu, 2025-04-10 at 15:27 +0200, Frederic Weisbecker wrote:
> > But how do we handle global timers that have been initialized and
> > queued from
> > isolated CPUs?
> 
> I need to sketch a bit more the solution but the rough idea is:
> 1. isolated CPUs don't pull remote timers

That's the "easy" part.

> 2. isolated CPUs ignore their global timers and let others pull them
>   perhaps with some more logic to avoid it expiring

This will always involve added overhead because you may need to wake up
a CPU upon enqueueing a global timer to make sure it will be handled.
At least when all other CPUs are idle.

> Wouldn't that be sufficient?
> 
> Also, I would definitely do 1. for any kind of isolation, but I'm not
> sure about 2.
> Strictly speaking domain isolated cores don't claim to be free of
> kernel noise, even if they initiate it (but nohz_full ones do).
> What would be the expectation there?

I don't know, I haven't heard complains about isolcpus handling global
timers so far...

I wouldn't pay much attention to 2) until anybody complains. Does 1) even
matter to anybody outside nohz_full ?

Thanks.

-- 
Frederic Weisbecker
SUSE Labs

  reply	other threads:[~2025-04-10 14:20 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-10  6:54 [PATCH] timers: Exclude isolated cpus from timer migation Gabriele Monaco
2025-04-10  8:26 ` Thomas Gleixner
2025-04-10 10:38   ` Gabriele Monaco
2025-04-10 13:03     ` Frederic Weisbecker
2025-04-10 13:15       ` Thomas Gleixner
2025-04-10 13:27         ` Frederic Weisbecker
2025-04-10 13:56           ` Gabriele Monaco
2025-04-10 14:20             ` Frederic Weisbecker [this message]
2025-04-10 14:46               ` Thomas Gleixner
2025-04-10 14:54                 ` Frederic Weisbecker
2025-04-10 15:06                   ` Waiman Long
2025-04-10 14:46               ` Gabriele Monaco
2025-04-10 14:59                 ` Frederic Weisbecker
2025-04-10 15:05                   ` Gabriele Monaco
2025-04-10 15:32                     ` Frederic Weisbecker
2025-04-11  7:08                       ` Gabriele Monaco
2025-04-11 11:31                         ` Frederic Weisbecker
2025-04-11 13:02                           ` Gabriele Monaco
2025-04-11 22:57                             ` Frederic Weisbecker
2025-04-14  8:06                               ` Gabriele Monaco
2025-04-10 14:35       ` Waiman Long
2025-04-10 14:43         ` Frederic Weisbecker
2025-04-10 14:49           ` Gabriele Monaco
2025-04-10 14:50           ` Waiman Long
2025-04-10 14:56             ` Frederic Weisbecker
2025-04-10 13:08     ` Thomas Gleixner
2025-04-10 14:21     ` Waiman Long
2025-04-10 14:32 ` Waiman Long
2025-04-11  7:12 ` kernel test robot
2025-04-11  9:27 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z_fTmzdvLEmrAth6@localhost.localdomain \
    --to=frederic@kernel.org \
    --cc=gmonaco@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.