From: Christoph Hellwig <hch@infradead.org>
To: Ackerley Tng <ackerleytng@google.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Shivank Garg <shivankg@amd.com>,
seanjc@google.com, david@redhat.com, vbabka@suse.cz,
willy@infradead.org, akpm@linux-foundation.org, shuah@kernel.org,
pbonzini@redhat.com, paul@paul-moore.com, jmorris@namei.org,
serge@hallyn.com, pvorel@suse.cz, bfoster@redhat.com,
tabba@google.com, vannapurve@google.com, chao.gao@intel.com,
bharata@amd.com, nikunj@amd.com, michael.day@amd.com,
yan.y.zhao@intel.com, Neeraj.Upadhyay@amd.com,
thomas.lendacky@amd.com, michael.roth@amd.com, aik@amd.com,
jgg@nvidia.com, kalyazin@amazon.com, peterx@redhat.com,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, kvm@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-coco@lists.linux.dev
Subject: Re: [PATCH RFC v7 5/8] KVM: guest_memfd: Make guest mem use guest mem inodes instead of anonymous inodes
Date: Thu, 10 Apr 2025 07:23:24 -0700 [thread overview]
Message-ID: <Z_fUXKcvbbUTQO1n@infradead.org> (raw)
In-Reply-To: <diqz4iyw5dis.fsf@ackerleytng-ctop.c.googlers.com>
On Thu, Apr 10, 2025 at 06:53:15AM -0700, Ackerley Tng wrote:
> > So why do other alloc_anon_inode callers not need
> > security_inode_init_security_anon?
>
> Thanks for this tip!
>
> When I did this refactoring, I was just refactoring
> anon_inode_create_getfile(), to set up the guest_memfd inode and file in
> separate stages, and anon_inode_create_getfile() was already using
> security_inode_init_security_anon().
>
> In the next revision I can remove this call.
>
> Is it too late to remove the call to security_inode_init_security_anon()
> though? IIUC it is used by LSMs, which means security modules may
> already be assuming this call?
I'd really like to here from the security folks if we need it or not,
both in this case and for other alloc_anon_inode callers.
next prev parent reply other threads:[~2025-04-10 14:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 11:23 [PATCH RFC v7 0/8] Add NUMA mempolicy support for KVM guest-memfd Shivank Garg
2025-04-08 11:23 ` [PATCH RFC v7 1/8] mm/filemap: Add mempolicy support to the filemap layer Shivank Garg
2025-04-08 11:23 ` [PATCH RFC v7 2/8] mm/mempolicy: Export memory policy symbols Shivank Garg
2025-04-08 11:23 ` [PATCH RFC v7 3/8] security: Export security_inode_init_security_anon for KVM guest_memfd Shivank Garg
2025-04-09 20:19 ` Paul Moore
2025-04-11 6:07 ` Shivank Garg
2025-04-22 16:49 ` David Hildenbrand
2025-04-10 8:41 ` Christoph Hellwig
2025-04-11 6:51 ` Shivank Garg
2025-04-22 17:25 ` David Hildenbrand
2025-05-08 6:37 ` Shivank Garg
2025-04-08 11:23 ` [PATCH RFC v7 4/8] KVM: Add kvm_gmem_exit() cleanup function Shivank Garg
2025-04-08 11:23 ` [PATCH RFC v7 5/8] KVM: guest_memfd: Make guest mem use guest mem inodes instead of anonymous inodes Shivank Garg
2025-04-10 8:42 ` Christoph Hellwig
2025-04-10 13:53 ` Ackerley Tng
2025-04-10 14:23 ` Christoph Hellwig [this message]
2025-04-08 11:24 ` [PATCH RFC v7 6/8] KVM: guest_memfd: Add slab-allocated inode cache Shivank Garg
2025-04-08 11:24 ` [PATCH RFC v7 7/8] KVM: guest_memfd: Enforce NUMA mempolicy using shared policy Shivank Garg
2025-04-10 13:40 ` Ackerley Tng
2025-04-11 6:42 ` Shivank Garg
2025-04-08 11:24 ` [PATCH RFC v7 8/8] KVM: guest_memfd: selftests: Add tests for mmap and NUMA policy support Shivank Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_fUXKcvbbUTQO1n@infradead.org \
--to=hch@infradead.org \
--cc=Neeraj.Upadhyay@amd.com \
--cc=ackerleytng@google.com \
--cc=aik@amd.com \
--cc=akpm@linux-foundation.org \
--cc=bfoster@redhat.com \
--cc=bharata@amd.com \
--cc=chao.gao@intel.com \
--cc=david@redhat.com \
--cc=jgg@nvidia.com \
--cc=jmorris@namei.org \
--cc=kalyazin@amazon.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=michael.day@amd.com \
--cc=michael.roth@amd.com \
--cc=nikunj@amd.com \
--cc=paul@paul-moore.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=pvorel@suse.cz \
--cc=seanjc@google.com \
--cc=serge@hallyn.com \
--cc=shivankg@amd.com \
--cc=shuah@kernel.org \
--cc=tabba@google.com \
--cc=thomas.lendacky@amd.com \
--cc=vannapurve@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.