From: Michael Klein <michael@fossekall.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Joe Damato <jdamato@fastly.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND net-next v5 1/4] net: phy: realtek: Group RTL82* macro definitions
Date: Fri, 11 Apr 2025 00:05:25 +0200 [thread overview]
Message-ID: <Z_hApRl14nSgwtCu@a98shuttle.de> (raw)
In-Reply-To: <96fcff68-6a96-49fe-b771-629d3bef03ea@lunn.ch>
On Tue, Apr 08, 2025 at 02:17:19PM +0200, Andrew Lunn wrote:
>On Mon, Apr 07, 2025 at 07:52:50PM -0700, Joe Damato wrote:
>> On Mon, Apr 07, 2025 at 08:21:40PM +0200, Michael Klein wrote:
>> > #define RTL821x_PHYSR 0x11
>> > #define RTL821x_PHYSR_DUPLEX BIT(13)
>> > #define RTL821x_PHYSR_SPEED GENMASK(15, 14)
>> > @@ -31,6 +40,10 @@
>> > #define RTL821x_EXT_PAGE_SELECT 0x1e
>> > #define RTL821x_PAGE_SELECT 0x1f
>> >
>> > +#define RTL8211E_CTRL_DELAY BIT(13)
>> > +#define RTL8211E_TX_DELAY BIT(12)
>> > +#define RTL8211E_RX_DELAY BIT(11)
>>
>> Maybe I'm reading this wrong but these don't seem sorted
>> lexicographically ?
>
>This i don't follow, you normally keep register bits next to the
>register. This is particularly important when the register bits don't
>have the register name embedded within it.
Well, there is no definition for the register these bits pertain to,
and adding one in _this_ patch would break the scope of this change. So
I will address this in a later patch of this series in the next version.
--
Michael
next prev parent reply other threads:[~2025-04-10 22:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 18:21 [RESEND net-next v5 0/4] net: phy: realtek: Add support for PHY LEDs on Michael Klein
2025-04-07 18:21 ` [RESEND net-next v5 1/4] net: phy: realtek: Group RTL82* macro definitions Michael Klein
2025-04-08 2:52 ` Joe Damato
2025-04-08 12:17 ` Andrew Lunn
2025-04-08 14:27 ` Russell King (Oracle)
2025-04-10 22:05 ` Michael Klein [this message]
2025-04-07 18:21 ` [RESEND net-next v5 2/4] net: phy: realtek: Clean up RTL8211E ExtPage access Michael Klein
2025-04-08 2:56 ` Joe Damato
2025-04-08 18:47 ` Michael Klein
2025-04-08 19:21 ` Andrew Lunn
2025-04-07 18:21 ` [RESEND net-next v5 3/4] net: phy: realtek: use __set_bit() in rtl8211f_led_hw_control_get() Michael Klein
2025-04-07 18:21 ` [RESEND net-next v5 4/4] net: phy: realtek: Add support for PHY LEDs on RTL8211E Michael Klein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_hApRl14nSgwtCu@a98shuttle.de \
--to=michael@fossekall.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.