Re: [PATCH 4/5] ARM: dts: renesas: r9a06g032-rzn1d400-db: describe LEDs

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]


> These are called LED1-LED8 in the Board Setup Notes.

Oh, where? I have a version from "Dec 14, 2020" which only calls them
Software-LEDs or "Port0 BitX". Schematics call them DBG_LEDx. I don't
care much. The "db" board has a "USER LED2", as long as we don't
conflict with that name, I am fine.

>     color = <LED_COLOR_ID_ORANGE>;

Hmmm, they are definitely GREEN here.

>     function = LED_FUNCTION_INDICATOR;

LED_FUNCTION_PROGRAMMING?

> Perhaps you want the first one to be a heartbeat?
> 
>     linux,default-trigger = "heartbeat";

I recently removed a default-trigger on another board because it was in
the way. So, I'd rather not.

Phew, starting with the PHY LEDs on this board, didn't know LED were so
troublesome...

Shall I resend only this patch and rebased on the keyboard patch? Or
resend the both?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]