From: Sean Christopherson <seanjc@google.com>
To: ross.philipson@oracle.com
Cc: ALOK TIWARI <alok.a.tiwari@oracle.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-integrity@vger.kernel.org, linux-doc@vger.kernel.org,
linux-crypto@vger.kernel.org, kexec@lists.infradead.org,
linux-efi@vger.kernel.org, iommu@lists.linux.dev,
dpsmith@apertussolutions.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
dave.hansen@linux.intel.com, ardb@kernel.org,
mjg59@srcf.ucam.org, James.Bottomley@hansenpartnership.com,
peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca,
luto@amacapital.net, nivedita@alum.mit.edu,
herbert@gondor.apana.org.au, davem@davemloft.net,
corbet@lwn.net, ebiederm@xmission.com, dwmw2@infradead.org,
baolu.lu@linux.intel.com, kanth.ghatraju@oracle.com,
andrew.cooper3@citrix.com, trenchboot-devel@googlegroups.com
Subject: Re: [PATCH v13 01/19] Documentation/x86: Secure Launch kernel documentation
Date: Fri, 11 Apr 2025 14:32:49 -0700 [thread overview]
Message-ID: <Z_mKgfZznBZgS-Pb@google.com> (raw)
In-Reply-To: <b06b187a-54e2-460e-8fc5-b440184b6f7a@oracle.com>
On Fri, Apr 11, 2025, ross.philipson@oracle.com wrote:
> On 4/10/25 10:50 PM, ALOK TIWARI wrote:
> >
> >
> > On 11-04-2025 02:11, Ross Philipson wrote:
> > > +
> > > + - Entry from the dynamic launch jumps to the SL stub.
> > > + - SL stub fixes up the world on the BSP.
> > > + - For TXT, SL stub wakes the APs, fixes up their worlds.
> > > + - For TXT, APs are left halted using MONITOR/MWAIT intructions.
> >
> > typo intructions -> instruction
>
> Thanks for the review. They are two separate instructions so is this really
> incorrect?
From the peanut gallery, I'd just drop the "instruction(s)" qualifier, i.e.
- For TXT, APs are left halted using MONITOR/MWAIT.
Pedantically, it's the combination of MONTIOR+MWAIT that puts the CPU into a
sleep state, not the individual instructions.
And while I'm picking nits, the documentation is also a bit misleading as the CPU
isn't halted per se. I'd go with something like:
- For TXT, APs are left in an optimized (MONITOR/MWAIT) wait state.
next prev parent reply other threads:[~2025-04-11 21:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 20:41 [PATCH v13 00/19] x86: Trenchboot secure dynamic launch Linux kernel support Ross Philipson
2025-04-10 20:41 ` [PATCH v13 01/19] Documentation/x86: Secure Launch kernel documentation Ross Philipson
2025-04-11 5:50 ` ALOK TIWARI
2025-04-11 19:41 ` ross.philipson
2025-04-11 21:32 ` Sean Christopherson [this message]
2025-04-15 20:44 ` ross.philipson
2025-04-12 16:07 ` ALOK TIWARI
2025-04-15 20:59 ` ross.philipson
2025-04-10 20:41 ` [PATCH v13 02/19] x86: Secure Launch Kconfig Ross Philipson
2025-04-10 20:41 ` [PATCH v13 03/19] x86: Secure Launch Resource Table header file Ross Philipson
2025-04-10 20:41 ` [PATCH v13 04/19] x86: Secure Launch main " Ross Philipson
2025-04-12 18:34 ` ALOK TIWARI
2025-04-15 21:04 ` ross.philipson
2025-04-10 20:41 ` [PATCH v13 05/19] x86: Add early SHA-1 support for Secure Launch early measurements Ross Philipson
2025-04-10 20:41 ` [PATCH v13 06/19] x86: Add early SHA-256 " Ross Philipson
2025-04-10 20:41 ` [PATCH v13 07/19] x86/msr: Add variable MTRR base/mask and x2apic ID registers Ross Philipson
2025-04-10 20:41 ` [PATCH v13 08/19] x86/boot: Place TXT MLE header in the kernel_info section Ross Philipson
2025-04-10 20:41 ` [PATCH v13 09/19] x86: Secure Launch kernel early boot stub Ross Philipson
2025-04-11 21:40 ` Sean Christopherson
2025-04-15 22:12 ` Andrew Cooper
2025-04-15 22:15 ` Sean Christopherson
2025-04-15 22:16 ` ross.philipson
2025-04-10 20:41 ` [PATCH v13 10/19] x86: Secure Launch kernel late " Ross Philipson
2025-04-10 20:41 ` [PATCH v13 11/19] x86: Secure Launch SMP bringup support Ross Philipson
2025-04-10 20:41 ` [PATCH v13 12/19] kexec: Secure Launch kexec SEXIT support Ross Philipson
2025-04-10 20:41 ` [PATCH v13 13/19] x86/reboot: Secure Launch SEXIT support on reboot paths Ross Philipson
2025-04-10 20:41 ` [PATCH v13 14/19] tpm, tpm_tis: Close all localities Ross Philipson
2025-04-10 20:41 ` [PATCH v13 15/19] tpm, tpm_tis: Address positive localities in tpm_tis_request_locality() Ross Philipson
2025-04-10 20:41 ` [PATCH v13 16/19] tpm, tpm_tis: Allow locality to be set to a different value Ross Philipson
2025-04-12 19:15 ` ALOK TIWARI
2025-04-15 21:04 ` ross.philipson
2025-04-10 20:41 ` [PATCH v13 17/19] tpm, sysfs: Show locality used by kernel Ross Philipson
2025-04-10 20:41 ` [PATCH v13 18/19] x86: Secure Launch late initcall platform module Ross Philipson
2025-04-10 20:41 ` [PATCH v13 19/19] x86/efi: EFI stub DRTM launch support for Secure Launch Ross Philipson
-- strict thread matches above, loose matches on Subject: below --
2025-03-28 23:07 [PATCH v13 00/19] x86: Trenchboot secure dynamic launch Linux kernel support Ross Philipson
2025-03-28 23:07 ` [PATCH v13 01/19] Documentation/x86: Secure Launch kernel documentation Ross Philipson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_mKgfZznBZgS-Pb@google.com \
--to=seanjc@google.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=ardb@kernel.org \
--cc=baolu.lu@linux.intel.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dpsmith@apertussolutions.com \
--cc=dwmw2@infradead.org \
--cc=ebiederm@xmission.com \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux.dev \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kanth.ghatraju@oracle.com \
--cc=kexec@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=mjg59@srcf.ucam.org \
--cc=nivedita@alum.mit.edu \
--cc=peterhuewe@gmx.de \
--cc=ross.philipson@oracle.com \
--cc=tglx@linutronix.de \
--cc=trenchboot-devel@googlegroups.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.