From: Danilo Krummrich <dakr@kernel.org>
To: Christian Schrefl <chrisi.schrefl@gmail.com>
Cc: "Luis Chamberlain" <mcgrof@kernel.org>,
"Russ Weight" <russ.weight@linux.dev>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v2] rust: Use `ffi::c_char` type in firmware abstraction `FwFunc`
Date: Sat, 12 Apr 2025 16:53:06 +0200 [thread overview]
Message-ID: <Z_p-UoycGk3BceXm@pollux> (raw)
In-Reply-To: <20250412-rust_arm_fix_fw_abstaction-v2-1-8e6fdf093d71@gmail.com>
On Sat, Apr 12, 2025 at 12:29:48PM +0200, Christian Schrefl wrote:
> The `FwFunc` struct contains an function with a char pointer argument,
> for which a `*const u8` pointer was used. This is not really the
> "propper" type for this, so use a `*const kernel::ffi::c_char` pointer
> instad.
>
> This has no real functionality changes, since `kernel::ffi::c_char` is
> a type alias to `u8` anyways.
>
> This used to cause problems on 6.13 when building for 32 bit arm (with
> my patches), since rust mapped c_char to i8 instead.
Now that I read this again:
Isn't it the other way around? For arm32 c_char was mapped to u8, but FwFunc
expected i8 (since that's what c_char was mapped to for all other architectures
that are supported in v6.13).
Can you please clarify this in the commit message?
next prev parent reply other threads:[~2025-04-12 14:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-12 10:29 [PATCH v2] rust: Use `ffi::c_char` type in firmware abstraction `FwFunc` Christian Schrefl
2025-04-12 11:59 ` Miguel Ojeda
2025-04-12 12:35 ` Danilo Krummrich
2025-04-12 14:05 ` Miguel Ojeda
2025-04-12 13:55 ` Christian Schrefl
2025-04-12 14:05 ` Miguel Ojeda
2025-04-12 14:53 ` Danilo Krummrich [this message]
2025-04-13 8:55 ` Christian Schrefl
2025-04-13 10:44 ` Danilo Krummrich
2025-04-13 15:07 ` Miguel Ojeda
2025-04-13 15:12 ` Christian Schrefl
2025-04-13 15:22 ` Miguel Ojeda
2025-04-13 15:32 ` Christian Schrefl
2025-04-13 15:43 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_p-UoycGk3BceXm@pollux \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=chrisi.schrefl@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=ojeda@kernel.org \
--cc=russ.weight@linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.