From: Breno Leitao <leitao@debian.org>
To: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Cc: mingo@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] x86/bugs: Add a separate config for missing mitigation
Date: Tue, 23 Jan 2024 07:05:47 -0800 [thread overview]
Message-ID: <Za/Vy2l1VwyI4DKH@gmail.com> (raw)
In-Reply-To: <20240122205821.m5dsyi4sc2ghoavd@desk>
On Mon, Jan 22, 2024 at 12:58:21PM -0800, Pawan Gupta wrote:
> On Thu, Jan 18, 2024 at 09:32:12AM -0800, Breno Leitao wrote:
> > +config MITIGATION_RETBLEED
> > + bool "Mitigate RETBleed hardware bug"
> > + depends on CPU_SUP_INTEL || (CPU_SUP_AMD && MITIGATION_UNRET_ENTRY)
>
> Atleast on Intel CPUs, Retbleed mitigation is meaningless without
> spectre-v2 being mitigated, shouldn't this depend on MITIGATION_SPECTRE_V2?
I suppose it is the same for AMD, right?
So, I suppose it should be something as:
depends on (MITIGATION_SPECTRE_V2 && (CPU_SUP_INTEL || (CPU_SUP_AMD && MITIGATION_UNRET_ENTRY))
Is this better?
Thanks!
next prev parent reply other threads:[~2024-01-23 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 17:32 [PATCH 0/3] x86/bugs: Separate config for mitigations (part 2) Breno Leitao
2024-01-18 17:32 ` [PATCH 1/3] x86/bugs: Create a way to disable GDS mitigation Breno Leitao
2024-01-18 17:32 ` [PATCH 2/3] x86/bugs: Add a separate config for missing mitigation Breno Leitao
2024-01-22 20:58 ` Pawan Gupta
2024-01-23 15:05 ` Breno Leitao [this message]
2024-01-24 0:06 ` Pawan Gupta
2024-01-18 17:32 ` [PATCH 3/3] x86/bugs: spectre_v2_user default mode depends on main default Breno Leitao
2024-01-23 0:04 ` Pawan Gupta
2024-01-23 15:02 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za/Vy2l1VwyI4DKH@gmail.com \
--to=leitao@debian.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.