From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5C50C4725D for ; Mon, 22 Jan 2024 08:25:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BlE+GW3nut5aBClL510tjaPZEx71coj5q79u+WQo/eU=; b=eu2NR+2hiq9GXq yK/FsQSY7qktrjmjm3pYUdDSATt4lAQsro2Sp4UaWG1doRO77Y0TvQADa8KEdTb5oiPkoiV8wSajf M3WBSAESKe/UgxDOhEoMK7ZSP5NbNJ5kGH43bi8yIQXeVZv9mrIBWLb3M/QKKj3JiZdWlrYHiqutm KZW2rNbQ1SaYrOedMqv96v14uKF9EDr1VGfL/PnlDX2tvIq8gPA0YjM50Murtvz6x+yHDfKUcei2F fzRhP6GCzGBtlEb4pCjgOLyl4zpn5BTlv9OZhgMTWD88pIFMiVqf3gtOnXpnCpv7dq/kJhQgPIFf0 pMy3PgDFJ8v9U8ftHGuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rRpcc-00B2ZA-2A; Mon, 22 Jan 2024 08:25:34 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rRpcZ-00B2Vz-1o for linux-riscv@lists.infradead.org; Mon, 22 Jan 2024 08:25:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705911928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bDmft0G/LbU/vGcrH0ViFbqfb55/2jbpdSGlzfSsB1Q=; b=Tq0Kr1MWX0KSxsm9olcGK5lIQDryQLr36bHs7p4buw8wePJUKh6BrP222hP+Pp0JKkefsJ F1e+Pb1nhWcqUGXV+pmk+Xu1hEzJlKXrfeB/uIdJ8mgTn9nbV6D+q3zlQjkIVyRE8Ips3S vz07mo4uUttYPWFUgtVxf9+qcHSELfU= Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-267-m_a4dr_GN_-CTr3MDMkOAQ-1; Mon, 22 Jan 2024 03:25:26 -0500 X-MC-Unique: m_a4dr_GN_-CTr3MDMkOAQ-1 Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-6ddeec294fdso742566a34.0 for ; Mon, 22 Jan 2024 00:25:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705911925; x=1706516725; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bDmft0G/LbU/vGcrH0ViFbqfb55/2jbpdSGlzfSsB1Q=; b=CJs/8il0UUHEGe5VgBdiHsTKqU7f55MF3qMPYqgOpMaAlDlEFuZe7fgvM5tGQL1+eu uoKomRwO5rxjXJs0p1wsZfPtbSXfutCkvU/LHBABDEhMRU8ul7RZxWz97SFd2C6mFgCn aNUy5baCfPNFY3/dkRFKtboSKSmD50T8R5rNRIR1ZyglbGqN4+XfyPbq6UcfJ3loJdMv ZPBiyjhL3+OnnMPlpfCzekIDiaIILgGbGl8jZ2ae9myHjZ0bOSannBmNVucmdTUz0X0K 52IYsRdvxr2vSWupO/rFgH3zB/ZR2RN0N14jr81ou57Wyz6ycrHhG2tat2WMutX7XYAP WMrw== X-Gm-Message-State: AOJu0YyH5MM94PcjkEQTftSyonlcCp03fMEs7YZh82cymhCUWyTc9262 QbZdVZkHVsc+sEKjH92YKGjWBTDawYp9nLW/xsnPbPXlZtFTXpvtvbcIxv1x5ufM4iWgH7kUig6 G8Rwc8aHR27VA1lMYvshRcivlaWXvPIMc+GeQ62hUw3smFaQiGtn5mY/qbax8Rc0cLQ== X-Received: by 2002:a05:6358:591d:b0:176:5ca9:7213 with SMTP id g29-20020a056358591d00b001765ca97213mr953016rwf.0.1705911925337; Mon, 22 Jan 2024 00:25:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSePoGNoX92PzQmVfT4AXX54k/+l1fGFhIaFtWONOwMEeDpGYerPythOMH74Vw9shCsROV9A== X-Received: by 2002:a05:6358:591d:b0:176:5ca9:7213 with SMTP id g29-20020a056358591d00b001765ca97213mr952991rwf.0.1705911925009; Mon, 22 Jan 2024 00:25:25 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id h8-20020a654808000000b005ca0ae17983sm6839110pgs.8.2024.01.22.00.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 00:25:24 -0800 (PST) Date: Mon, 22 Jan 2024 16:25:12 +0800 From: Peter Xu To: Jason Gunthorpe Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton , David Hildenbrand , "Kirill A . Shutemov" , Yang Shi , linux-riscv@lists.infradead.org, Andrew Morton , "Aneesh Kumar K . V" , Rik van Riel , Andrea Arcangeli , Axel Rasmussen , Mike Rapoport , John Hubbard , Vlastimil Babka , Michael Ellerman , Christophe Leroy , Andrew Jones , linuxppc-dev@lists.ozlabs.org, Mike Kravetz , Muchun Song , linux-arm-kernel@lists.infradead.org, Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox Subject: Re: [PATCH v2 01/13] mm/Kconfig: CONFIG_PGTABLE_HAS_HUGE_LEAVES Message-ID: References: <20240103091423.400294-1-peterx@redhat.com> <20240103091423.400294-2-peterx@redhat.com> <20240115173737.GO734935@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240115173737.GO734935@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240122_002531_667862_007CB93A X-CRM114-Status: GOOD ( 18.57 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Jan 15, 2024 at 01:37:37PM -0400, Jason Gunthorpe wrote: > On Wed, Jan 03, 2024 at 05:14:11PM +0800, peterx@redhat.com wrote: > > From: Peter Xu > > > > Introduce a config option that will be selected as long as huge leaves are > > involved in pgtable (thp or hugetlbfs). It would be useful to mark any > > code with this new config that can process either hugetlb or thp pages in > > any level that is higher than pte level. > > > > Signed-off-by: Peter Xu > > --- > > mm/Kconfig | 3 +++ > > 1 file changed, 3 insertions(+) > > So you mean anything that supports page table entires > PAGE_SIZE ? Yes. > > Makes sense to me, though maybe add a comment in the kconfig? Sure I'll add some. > > Reviewed-by: Jason Gunthorpe Thanks for your reviews and also positive comments in previous versions, Jason. I appreciate that. I'm just pretty occupied with other tasks recently so I don't yet have time to revisit this series, along with other comments yet. I'll do so and reply to the comments / discussions together afterwards. -- Peter Xu _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69E50C4725D for ; Mon, 22 Jan 2024 08:26:27 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JbcaLPtm; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JbcaLPtm; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TJNbj66THz3bn6 for ; Mon, 22 Jan 2024 19:26:25 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JbcaLPtm; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JbcaLPtm; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=peterx@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TJNZl6jFzz3bhr for ; Mon, 22 Jan 2024 19:25:34 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705911929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bDmft0G/LbU/vGcrH0ViFbqfb55/2jbpdSGlzfSsB1Q=; b=JbcaLPtma0c7RVKRwityo3dPbpZWFBGgmAiz1DtCVY5myz1E1LhOy51QqYnpfxKjQUWaar /ResMHj5/R7QIF79q0ecu/Ge00SSgc3M1pwT2i/d8RoXkheO6wt5aKysYDjnrAMiKTx+CO ML1VHyGbSRLlnz1MfArOMgidIRFQ9Vw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705911929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bDmft0G/LbU/vGcrH0ViFbqfb55/2jbpdSGlzfSsB1Q=; b=JbcaLPtma0c7RVKRwityo3dPbpZWFBGgmAiz1DtCVY5myz1E1LhOy51QqYnpfxKjQUWaar /ResMHj5/R7QIF79q0ecu/Ge00SSgc3M1pwT2i/d8RoXkheO6wt5aKysYDjnrAMiKTx+CO ML1VHyGbSRLlnz1MfArOMgidIRFQ9Vw= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-7-PzdxzIOtPGqQGuk8VDoi7g-1; Mon, 22 Jan 2024 03:25:26 -0500 X-MC-Unique: PzdxzIOtPGqQGuk8VDoi7g-1 Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-6ddeec294fdso742564a34.0 for ; Mon, 22 Jan 2024 00:25:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705911925; x=1706516725; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bDmft0G/LbU/vGcrH0ViFbqfb55/2jbpdSGlzfSsB1Q=; b=g8K8QPs7HEUmCGb+SqD0zUe0RauJKudy7/NiS9zTda8tjjlNfHxznAvjVth4UPTe4p ImTbk59A0MYIDUm1koxu4Lc7AuAvpKuxBw6NCsqKHvT/Dif6ccPS8kCfW6Z5NTZvp9pa 3jck7LwC3kak25JJ9Lo89g/gJGzW3Jyr0L9XTccs2UKwDZaJdNXcVpvK7gp0tOvq5kO4 57mYNZi68oAFiVR2vWi8JA78R5DzL9nUFPpShcl9+HIqnfaYRnl8imZFv9xcbum3HV2z jTJPmvz1XVU/qkNVJid4YQ1W2avAjgKjvb2X1z7unM8W8kK1VnbGvwqIqZ8NpIRARL/B /e8w== X-Gm-Message-State: AOJu0YyrESWbsuAPIpWu6w0ppBXqk4j3rrvOJGuMncbEdWI8252Pt9jm 95TSIjYgFW2qR50R8q7VbPZFkle18py/tfvZ45teUJw9y9G/lJDoJ9htVIp88IeSyEVryUix3kg B/mPOapaAGohwS0rLVhta0wXlnWWn/vEVItUMsHMpbT97VNfgPmfWk7jPmI9xSfA= X-Received: by 2002:a05:6358:591d:b0:176:5ca9:7213 with SMTP id g29-20020a056358591d00b001765ca97213mr953022rwf.0.1705911925340; Mon, 22 Jan 2024 00:25:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSePoGNoX92PzQmVfT4AXX54k/+l1fGFhIaFtWONOwMEeDpGYerPythOMH74Vw9shCsROV9A== X-Received: by 2002:a05:6358:591d:b0:176:5ca9:7213 with SMTP id g29-20020a056358591d00b001765ca97213mr952991rwf.0.1705911925009; Mon, 22 Jan 2024 00:25:25 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id h8-20020a654808000000b005ca0ae17983sm6839110pgs.8.2024.01.22.00.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 00:25:24 -0800 (PST) Date: Mon, 22 Jan 2024 16:25:12 +0800 From: Peter Xu To: Jason Gunthorpe Subject: Re: [PATCH v2 01/13] mm/Kconfig: CONFIG_PGTABLE_HAS_HUGE_LEAVES Message-ID: References: <20240103091423.400294-1-peterx@redhat.com> <20240103091423.400294-2-peterx@redhat.com> <20240115173737.GO734935@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240115173737.GO734935@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Houghton , David Hildenbrand , Yang Shi , Andrew Jones , linux-mm@kvack.org, Matthew Wilcox , linux-riscv@lists.infradead.org, Andrea Arcangeli , Christoph Hellwig , "Aneesh Kumar K . V" , Vlastimil Babka , Axel Rasmussen , Rik van Riel , John Hubbard , "Kirill A . Shutemov" , linux-arm-kernel@lists.infradead.org, Lorenzo Stoakes , Muchun Song , linux-kernel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, Mike Rapoport , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Jan 15, 2024 at 01:37:37PM -0400, Jason Gunthorpe wrote: > On Wed, Jan 03, 2024 at 05:14:11PM +0800, peterx@redhat.com wrote: > > From: Peter Xu > > > > Introduce a config option that will be selected as long as huge leaves are > > involved in pgtable (thp or hugetlbfs). It would be useful to mark any > > code with this new config that can process either hugetlb or thp pages in > > any level that is higher than pte level. > > > > Signed-off-by: Peter Xu > > --- > > mm/Kconfig | 3 +++ > > 1 file changed, 3 insertions(+) > > So you mean anything that supports page table entires > PAGE_SIZE ? Yes. > > Makes sense to me, though maybe add a comment in the kconfig? Sure I'll add some. > > Reviewed-by: Jason Gunthorpe Thanks for your reviews and also positive comments in previous versions, Jason. I appreciate that. I'm just pretty occupied with other tasks recently so I don't yet have time to revisit this series, along with other comments yet. I'll do so and reply to the comments / discussions together afterwards. -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 408B2C4725D for ; Mon, 22 Jan 2024 08:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yBGQVdim+B98Xbdbk1AKWLkofqRsDznTcjFYLNSBRb4=; b=gtg4/4nwgKukGs d7HBUOexafZT7cRDc3JOKzuCxkfmZjpi/0Ybbo5BozNxKr89hrPLvc34I1lxAWm9JgEIogdagOorH OG44nf2aGcVoUTuHdChd0JGNnnRNTnhnO0RiJNqzHRDRX8LHX9hRYCAUauTiiJHyWJDuoROk1m0vI r30EGASHe+bBqRiyI2pno/Yo91ZrzSkr/1cBU04c1a77/wf8c1SXLjASTgsiqXgNtJnyAKUaiHoii A7KxzYhIU6p4/UcbUWseEgTBgVk6uT7x3hBhw3gj7tyF8f4m7tVRVUn1RoKmUp4doTKaLUOwYGwYv ua1K0EVPrtMfbSc8Abtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rRpcd-00B2Zt-1E; Mon, 22 Jan 2024 08:25:35 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rRpcZ-00B2Vv-1p for linux-arm-kernel@lists.infradead.org; Mon, 22 Jan 2024 08:25:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705911928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bDmft0G/LbU/vGcrH0ViFbqfb55/2jbpdSGlzfSsB1Q=; b=Tq0Kr1MWX0KSxsm9olcGK5lIQDryQLr36bHs7p4buw8wePJUKh6BrP222hP+Pp0JKkefsJ F1e+Pb1nhWcqUGXV+pmk+Xu1hEzJlKXrfeB/uIdJ8mgTn9nbV6D+q3zlQjkIVyRE8Ips3S vz07mo4uUttYPWFUgtVxf9+qcHSELfU= Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-9A582VgGNOmuzmvwQtVTuw-1; Mon, 22 Jan 2024 03:25:26 -0500 X-MC-Unique: 9A582VgGNOmuzmvwQtVTuw-1 Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-6e0eeb361c7so257720a34.1 for ; Mon, 22 Jan 2024 00:25:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705911925; x=1706516725; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bDmft0G/LbU/vGcrH0ViFbqfb55/2jbpdSGlzfSsB1Q=; b=mjo5tYks9ccz7Bwv+YrYyZT6/H3zfhk/g14hZC0z6vdv4yGXYNpw5lr8ZjkhBz0MYh 2JlvzBZRUne6smL0l9wwqEtuSyV/J+ddRVsSyZBuveCZsZ4uXl2RreI3ZdYnJlCJc+kD yLhOu8+ygyaleZpT1QddeMf6MHd6lp+p+hvLZCSuaaoSWm11xOqJUG4wEfLgRLRYm68T zq+xxtZEV41DLuBHcBabx15JHV21ZRyU9zwya5a9AGk9SiiZADuY1gQi7cmjXO9flxRG 2GXoRRsZY0Tgr8GMIMt+H5skjw617q3IiPdRisa0Sbij1GoVjRn10F4DRva4VKqQPN+w m3hg== X-Gm-Message-State: AOJu0Yw143lQMhuXoEIlpQXYZ7k+ZJgKVIsg1EDRob8umQ1zf/SG7Jxu Oqe4HRa7ATniOmD1rE+rbZCLuNk55ASKWnDj6TPs1xtfZhAlW28WdMci84E1VpbE0iNqLIwcqli IZ2AaKkQgjAIdmAsgF76j31m3TaC+TBt7LFno6XQl8THsXCqZ5r0J2ypTqeAU4Q89cFbjRRUY X-Received: by 2002:a05:6358:591d:b0:176:5ca9:7213 with SMTP id g29-20020a056358591d00b001765ca97213mr953017rwf.0.1705911925341; Mon, 22 Jan 2024 00:25:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSePoGNoX92PzQmVfT4AXX54k/+l1fGFhIaFtWONOwMEeDpGYerPythOMH74Vw9shCsROV9A== X-Received: by 2002:a05:6358:591d:b0:176:5ca9:7213 with SMTP id g29-20020a056358591d00b001765ca97213mr952991rwf.0.1705911925009; Mon, 22 Jan 2024 00:25:25 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id h8-20020a654808000000b005ca0ae17983sm6839110pgs.8.2024.01.22.00.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 00:25:24 -0800 (PST) Date: Mon, 22 Jan 2024 16:25:12 +0800 From: Peter Xu To: Jason Gunthorpe Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton , David Hildenbrand , "Kirill A . Shutemov" , Yang Shi , linux-riscv@lists.infradead.org, Andrew Morton , "Aneesh Kumar K . V" , Rik van Riel , Andrea Arcangeli , Axel Rasmussen , Mike Rapoport , John Hubbard , Vlastimil Babka , Michael Ellerman , Christophe Leroy , Andrew Jones , linuxppc-dev@lists.ozlabs.org, Mike Kravetz , Muchun Song , linux-arm-kernel@lists.infradead.org, Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox Subject: Re: [PATCH v2 01/13] mm/Kconfig: CONFIG_PGTABLE_HAS_HUGE_LEAVES Message-ID: References: <20240103091423.400294-1-peterx@redhat.com> <20240103091423.400294-2-peterx@redhat.com> <20240115173737.GO734935@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240115173737.GO734935@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240122_002531_683363_46606746 X-CRM114-Status: GOOD ( 20.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 15, 2024 at 01:37:37PM -0400, Jason Gunthorpe wrote: > On Wed, Jan 03, 2024 at 05:14:11PM +0800, peterx@redhat.com wrote: > > From: Peter Xu > > > > Introduce a config option that will be selected as long as huge leaves are > > involved in pgtable (thp or hugetlbfs). It would be useful to mark any > > code with this new config that can process either hugetlb or thp pages in > > any level that is higher than pte level. > > > > Signed-off-by: Peter Xu > > --- > > mm/Kconfig | 3 +++ > > 1 file changed, 3 insertions(+) > > So you mean anything that supports page table entires > PAGE_SIZE ? Yes. > > Makes sense to me, though maybe add a comment in the kconfig? Sure I'll add some. > > Reviewed-by: Jason Gunthorpe Thanks for your reviews and also positive comments in previous versions, Jason. I appreciate that. I'm just pretty occupied with other tasks recently so I don't yet have time to revisit this series, along with other comments yet. I'll do so and reply to the comments / discussions together afterwards. -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1A44C4725D for ; Mon, 22 Jan 2024 08:25:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 099528D0002; Mon, 22 Jan 2024 03:25:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 04A308D0001; Mon, 22 Jan 2024 03:25:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E04C98D0002; Mon, 22 Jan 2024 03:25:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CF1808D0001 for ; Mon, 22 Jan 2024 03:25:32 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 707F5801A3 for ; Mon, 22 Jan 2024 08:25:32 +0000 (UTC) X-FDA: 81706262904.12.7ED3AC5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 6E9394000F for ; Mon, 22 Jan 2024 08:25:29 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Tq0Kr1MW; spf=pass (imf04.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705911930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bDmft0G/LbU/vGcrH0ViFbqfb55/2jbpdSGlzfSsB1Q=; b=jYDPqI2Ix7XBjEk7Ij/4QiTmzfkUcT1mKnnJcCh3cdZNOFd81CiVCgt5pRQCqQX8ihKziJ Ssx54gv744+47p5IPet6MFV0zuXQ+rkGnwp+gGCNh2KPB8KwULOwey2mo3cfnCSWfq1Cmt XOJP1wA1ToOTFPdSnqOoxdUxM4L6t5s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705911930; a=rsa-sha256; cv=none; b=gnjiOs8fT56zxpN+xy1KXNdxHlERJn0a1GQSoGqttt3CjADX4+keK6BIJI1/PEsjVQAtrZ nCDt9TWTQAzR0XbMjUhQi9VmPls5WfpRUiC1E/XuGC/9xvsy/RZqLnwPIsGlXOydFrSH+z Za3QP5hxEaHRe+3YJnbXThyQAlYrEbA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Tq0Kr1MW; spf=pass (imf04.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705911928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bDmft0G/LbU/vGcrH0ViFbqfb55/2jbpdSGlzfSsB1Q=; b=Tq0Kr1MWX0KSxsm9olcGK5lIQDryQLr36bHs7p4buw8wePJUKh6BrP222hP+Pp0JKkefsJ F1e+Pb1nhWcqUGXV+pmk+Xu1hEzJlKXrfeB/uIdJ8mgTn9nbV6D+q3zlQjkIVyRE8Ips3S vz07mo4uUttYPWFUgtVxf9+qcHSELfU= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-7-G0FAMO4xO1O55EAGsNhabQ-1; Mon, 22 Jan 2024 03:25:26 -0500 X-MC-Unique: G0FAMO4xO1O55EAGsNhabQ-1 Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-6ddeec294fdso742559a34.0 for ; Mon, 22 Jan 2024 00:25:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705911925; x=1706516725; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bDmft0G/LbU/vGcrH0ViFbqfb55/2jbpdSGlzfSsB1Q=; b=ZeSUWMS8iV88dYRmNWdCjsIl05oZJeMbX/gOo2PSpm8N/l15FIcV87jtTsLzLyAtur Ud6hGF3I++OPkC+RYmkUgF0ciLRFuP9uNQj24Y26wuOk6gH80Ay8SImyz5yfH89qoym7 MoTLvWKIyNB4e/NeZRKGZuJyPly/cpsDDtzilQK6+t3i42KVxBEHGypT9t1Ck7T1vQdv I+CD5qqQVPQLGkSez1nfbmy8pGDR/FR18MBit95PSiKrQzzFCTR+diaISuKwa0B9zmlB yLrc/0H+2nyak1jQfha2rT6QLOGLHN8JLZTaNE32HEjdlWZnVjxW9TSAH/ZFpmQ6GN5W 8wsg== X-Gm-Message-State: AOJu0YxHA+FsQG11czObDtLC6got/zIuZKB3tvqsYVK+PzsYYznYh7FX HG8otV+2nY0mISA5SGQFk+OrfmDoUAgHiksIgDmOVLfTlzyuvnNDSrPl+7sbkDSgGl0K0dLR6sc 97oJVbGI8BEt7aQ26ec2nNLevvXzAYiN4XI1KuLWpJ35YPNYG X-Received: by 2002:a05:6358:591d:b0:176:5ca9:7213 with SMTP id g29-20020a056358591d00b001765ca97213mr953010rwf.0.1705911925334; Mon, 22 Jan 2024 00:25:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSePoGNoX92PzQmVfT4AXX54k/+l1fGFhIaFtWONOwMEeDpGYerPythOMH74Vw9shCsROV9A== X-Received: by 2002:a05:6358:591d:b0:176:5ca9:7213 with SMTP id g29-20020a056358591d00b001765ca97213mr952991rwf.0.1705911925009; Mon, 22 Jan 2024 00:25:25 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id h8-20020a654808000000b005ca0ae17983sm6839110pgs.8.2024.01.22.00.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 00:25:24 -0800 (PST) Date: Mon, 22 Jan 2024 16:25:12 +0800 From: Peter Xu To: Jason Gunthorpe Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton , David Hildenbrand , "Kirill A . Shutemov" , Yang Shi , linux-riscv@lists.infradead.org, Andrew Morton , "Aneesh Kumar K . V" , Rik van Riel , Andrea Arcangeli , Axel Rasmussen , Mike Rapoport , John Hubbard , Vlastimil Babka , Michael Ellerman , Christophe Leroy , Andrew Jones , linuxppc-dev@lists.ozlabs.org, Mike Kravetz , Muchun Song , linux-arm-kernel@lists.infradead.org, Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox Subject: Re: [PATCH v2 01/13] mm/Kconfig: CONFIG_PGTABLE_HAS_HUGE_LEAVES Message-ID: References: <20240103091423.400294-1-peterx@redhat.com> <20240103091423.400294-2-peterx@redhat.com> <20240115173737.GO734935@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240115173737.GO734935@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 6E9394000F X-Rspam-User: X-Stat-Signature: rh75kb7m567njq8tudiykf147r1cmpqf X-Rspamd-Server: rspam03 X-HE-Tag: 1705911929-86919 X-HE-Meta: U2FsdGVkX18fB8rJrkTfjyPf3TJMmuVkzCT3ihZH5kmkyD3XXE6LKXX1G+JHRogvMjvzPAbyRvO9oYfOdPB3noXRKwjSXKgFcCO3aWrS7S9lTAsNh6cnyE7ffMz1qdiLFgJRj4Zxwf7gTxdz10VJJZis/x3edGWMyVgW8eE+TpLDgXy8hKD5kL14PaIdXO6fTKEK/IaVCRLEjqXpE0AOmqLvWqJLRPngXDhj7Uxt4+yBatIRHwNmC42uIp7aVL1WDvYeSG1vGvAtyvUZMjKJ0CpFzvp9Upwm0oI5DclspboxAC/bXHYtkJHV0/6Y0JDE06fyWNlPcGqRjovyfYYJe6n+LjPzecBMmVBpg8raZlaIzAKAtBs0VU4nRhKNOjXD4vTXEuKDXmPKS8Ykd7Nkp/ti6SXr8DrzfFQMQ8BrUBTL70YjIk8qYSnY3nNCh9Z3WWLP/S6nkX1409GuNdLIS5jFKoRDCm5pyAdVrHOt20uLKGGEFbcu9iZhzyuQp/8Ca2QV9wpkqqqy/KW8bm5WRnAMu4AZRyjXB1ZoRx+5LrFSGl9nqAtLQBeCAhu0Xb54IhEUc8zq0iRYE269/kGbTMiUUYTWefDLd1KxLsle65JPgAx6GgQd0Vj4zgcx8LNB2xxhwbgxYBvOdQJHpnpF992NLKihgp//P3eS2YOXuYdgm2sc132r93enf/UwKON4Sd1/kkAOx4ccKWxq9Gy/GrimjW3HbAa9kJVy5IJYW3oeviI1Sl92aS2UC+ps2Q8btAXcqj66CiYVz+vXnZqvb2QBwbcpB2ETdNrb3dqs7nsuG9n1/c0bDJELN/mFtK9hp9Lk6tEoHewT4bHKX+PByUpKYsaFeMVI7Hi3hcIH1SuXe0uXzzcSAS1hcrSRhGDJvmAjRDiSwcO5l3D3nCLAeqhx1LuFA+VofDSePCdgWsFSywRvK4Y4x7nba9p8SEGEN/XAie8DOYOBwmP/9kn 46CSiGNz ApLIXX3rAVf0d+wZhKD5QLoNBuDGUA0iz6iiv+0MSAIr9gvmFr0k9ix/VXArzEOGkM/AYRk7cps0vkfEthfJ4dBaFfMp5EIY5FJEuWIkVroCVFaXsHu+AKg9iQ+bon3NhqKSmo6sO42d90SeYXD9nutX6iikmQpJpOZbNUgF6NDXYGB225JB3RJqRN2pw3fC1htxdPG21xYedzV1EjRITivpiYA3PcmzeTiLptONoOkArcZIE+WSH9k0PNrqFayyavKAUuOsCvc5y+pDe4nY0fEVn7cDU4N9JUBvnwbziOLc+eqd/l4pepxlGoeHMaL+Qg+Nlh/ofSKHxPzSE9GyY+4UBeY9pIXJA2u0Bkrp+yAYapoyuQjWmY/N5QFG26gckKdYwP6pDVbRBRqs0iMA1dBKDakcEyINKzgOuJRX3kA9GM9iQ00m3XQpLt9lGZBRwWZPcR+lhujGjo24= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 15, 2024 at 01:37:37PM -0400, Jason Gunthorpe wrote: > On Wed, Jan 03, 2024 at 05:14:11PM +0800, peterx@redhat.com wrote: > > From: Peter Xu > > > > Introduce a config option that will be selected as long as huge leaves are > > involved in pgtable (thp or hugetlbfs). It would be useful to mark any > > code with this new config that can process either hugetlb or thp pages in > > any level that is higher than pte level. > > > > Signed-off-by: Peter Xu > > --- > > mm/Kconfig | 3 +++ > > 1 file changed, 3 insertions(+) > > So you mean anything that supports page table entires > PAGE_SIZE ? Yes. > > Makes sense to me, though maybe add a comment in the kconfig? Sure I'll add some. > > Reviewed-by: Jason Gunthorpe Thanks for your reviews and also positive comments in previous versions, Jason. I appreciate that. I'm just pretty occupied with other tasks recently so I don't yet have time to revisit this series, along with other comments yet. I'll do so and reply to the comments / discussions together afterwards. -- Peter Xu