From: Guillaume Nault <gnault@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Martin KaFai Lau <kafai@fb.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 4/9] inet_diag: allow concurrent operations
Date: Mon, 22 Jan 2024 17:58:34 +0100 [thread overview]
Message-ID: <Za6euh/VzIiyU1Nw@debian> (raw)
In-Reply-To: <20240122112603.3270097-5-edumazet@google.com>
On Mon, Jan 22, 2024 at 11:25:58AM +0000, Eric Dumazet wrote:
> inet_diag_lock_handler() current implementation uses a mutex
> to protect inet_diag_table[] array against concurrent changes.
>
> This makes inet_diag dump serialized, thus less scalable
> than legacy /proc files.
>
> It is time to switch to full RCU protection.
>
> As a bonus, if a target is statically linked instead of being
> modular, inet_diag_lock_handler() & inet_diag_unlock_handler()
> reduce to reads only.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Guillaume Nault <gnault@redhat.com>
next prev parent reply other threads:[~2024-01-22 16:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 11:25 [PATCH net-next 0/9] inet_diag: remove three mutexes in diag dumps Eric Dumazet
2024-01-22 11:25 ` [PATCH net-next 1/9] sock_diag: annotate data-races around sock_diag_handlers[family] Eric Dumazet
2024-01-22 16:29 ` Guillaume Nault
2024-01-22 22:36 ` Kuniyuki Iwashima
2024-01-22 11:25 ` [PATCH net-next 2/9] inet_diag: annotate data-races around inet_diag_table[] Eric Dumazet
2024-01-22 16:29 ` Guillaume Nault
2024-01-22 22:37 ` Kuniyuki Iwashima
2024-01-22 11:25 ` [PATCH net-next 3/9] inet_diag: add module pointer to "struct inet_diag_handler" Eric Dumazet
2024-01-22 16:58 ` Guillaume Nault
2024-01-22 22:38 ` Kuniyuki Iwashima
2024-01-22 11:25 ` [PATCH net-next 4/9] inet_diag: allow concurrent operations Eric Dumazet
2024-01-22 16:58 ` Guillaume Nault [this message]
2024-01-22 22:40 ` Kuniyuki Iwashima
2024-01-22 11:25 ` [PATCH net-next 5/9] sock_diag: add module pointer to "struct sock_diag_handler" Eric Dumazet
2024-01-22 17:24 ` Guillaume Nault
2024-01-22 22:44 ` Kuniyuki Iwashima
2024-01-22 11:26 ` [PATCH net-next 6/9] sock_diag: allow concurrent operations Eric Dumazet
2024-01-22 17:25 ` Guillaume Nault
2024-01-22 22:47 ` Kuniyuki Iwashima
2024-01-22 11:26 ` [PATCH net-next 7/9] sock_diag: allow concurrent operation in sock_diag_rcv_msg() Eric Dumazet
2024-01-22 17:25 ` Guillaume Nault
2024-01-22 22:51 ` Kuniyuki Iwashima
2024-01-22 11:26 ` [PATCH net-next 8/9] sock_diag: remove sock_diag_mutex Eric Dumazet
2024-01-22 21:38 ` Guillaume Nault
2024-01-22 22:55 ` Kuniyuki Iwashima
2024-01-22 11:26 ` [PATCH net-next 9/9] inet_diag: skip over empty buckets Eric Dumazet
2024-01-22 21:44 ` Guillaume Nault
2024-01-22 22:58 ` Kuniyuki Iwashima
2024-01-22 15:05 ` [PATCH net-next 0/9] inet_diag: remove three mutexes in diag dumps Willem de Bruijn
2024-01-23 14:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za6euh/VzIiyU1Nw@debian \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kafai@fb.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.