From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH v4 2/3] tests/xe_waitfence: Removed drm_xe_sync data in exec_queue_reset_wait
Date: Mon, 22 Jan 2024 15:53:27 -0500 [thread overview]
Message-ID: <Za7VxwYK3Ztgyvdk@intel.com> (raw)
In-Reply-To: <20240122024543.456795-3-krishnaiah.bommu@intel.com>
On Mon, Jan 22, 2024 at 08:15:42AM +0530, Bommu Krishnaiah wrote:
> drm_xe_sync flags are declared wrongly and drm_xe_sync data is not used
> in this test, hence removing drm_xe_sync which is unused.
>
> Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> tests/intel/xe_waitfence.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/tests/intel/xe_waitfence.c b/tests/intel/xe_waitfence.c
> index dfdb97fb5..e6354b3ff 100644
> --- a/tests/intel/xe_waitfence.c
> +++ b/tests/intel/xe_waitfence.c
> @@ -221,16 +221,8 @@ exec_queue_reset_wait(int fd)
> uint32_t data;
> } *data;
>
> -#define USER_FENCE_VALUE 0xdeadbeefdeadbeefull
> - struct drm_xe_sync sync[1] = {
> - { .flags = DRM_XE_SYNC_TYPE_USER_FENCE | DRM_XE_SYNC_FLAG_SIGNAL,
> - .timeline_value = USER_FENCE_VALUE },
> - };
> -
> struct drm_xe_exec exec = {
> .num_batch_buffer = 1,
> - .num_syncs = 1,
> - .syncs = to_user_pointer(sync),
> };
>
> uint32_t vm = xe_vm_create(fd, 0, 0);
> --
> 2.25.1
>
next prev parent reply other threads:[~2024-01-22 20:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 2:45 [PATCH v4 0/3] tests/xe_waitfence: removed invalid_engine subtest Bommu Krishnaiah
2024-01-22 2:45 ` [PATCH v4 1/3] tests/xe_waitfence: remove invalid_engine subtest from xe_waitfence Bommu Krishnaiah
2024-01-22 20:53 ` Rodrigo Vivi
2024-01-22 2:45 ` [PATCH v4 2/3] tests/xe_waitfence: Removed drm_xe_sync data in exec_queue_reset_wait Bommu Krishnaiah
2024-01-22 20:53 ` Rodrigo Vivi [this message]
2024-01-22 2:45 ` [PATCH v4 3/3] tests/xe_waitfence: Removed duplicate code in waitfence Bommu Krishnaiah
2024-01-22 20:54 ` Rodrigo Vivi
2024-01-22 3:13 ` ✓ CI.xeBAT: success for tests/xe_waitfence: removed invalid_engine subtest (rev4) Patchwork
2024-01-22 3:33 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za7VxwYK3Ztgyvdk@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=krishnaiah.bommu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.