From: Mike Snitzer <snitzer@kernel.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Mikulas Patocka <mpatocka@redhat.com>,
dm-devel@lists.linux.dev
Subject: Re: [PATCHSET 0/3] Integrity cleanups and optimization
Date: Thu, 11 Jan 2024 11:34:08 -0500 [thread overview]
Message-ID: <ZaAYgJ+xK6c5p1/L@redhat.com> (raw)
In-Reply-To: <yq1o7dr6e09.fsf@ca-mkp.ca.oracle.com>
On Thu, Jan 11 2024 at 11:24P -0500,
Martin K. Petersen <martin.petersen@oracle.com> wrote:
>
> > Bw, can someone help with what dm_integrity_profile is for?
> > It is basically identical to the no-op one, just with a different
> > name. With the no-op removal it is the only one outside of the pi
> > once, and killing it would really help with some de-virtualization
> > I've looked at a while ago.
>
> No particular objections from me wrt. using a flag.
>
> However, I believe the no-op profile and associated plumbing was a
> requirement for DM. I forget the details. Mike?
I'll have to take a closer look.. staking device always complicates
things.
But the dummy functions that got wired up with this commit are suspect:
54d4e6ab91eb block: centralize PI remapping logic to the block layer
Effectively the entirety of the dm_integrity_profile is "we don't do
anything special".. so yes it would be nice to not require indirect
calls to accomplish what dm-integrity needs from block core.
Mike
next prev parent reply other threads:[~2024-01-11 16:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 16:00 [PATCHSET 0/3] Integrity cleanups and optimization Jens Axboe
2024-01-11 16:00 ` [PATCH 1/3] block/integrity: make profile optional Jens Axboe
2024-01-11 16:05 ` Christoph Hellwig
2024-01-11 16:09 ` Keith Busch
2024-01-11 16:19 ` Jens Axboe
2024-01-11 16:00 ` [PATCH 2/3] block/integrity: flag the queue if it has an integrity profile Jens Axboe
2024-01-11 16:06 ` Christoph Hellwig
2024-01-11 16:16 ` Jens Axboe
2024-01-11 16:18 ` Christoph Hellwig
2024-01-11 16:00 ` [PATCH 3/3] block: only call bio_integrity_prep() if necessary Jens Axboe
2024-01-11 16:28 ` Keith Busch
2024-01-11 18:50 ` Jens Axboe
2024-01-11 16:08 ` [PATCHSET 0/3] Integrity cleanups and optimization Christoph Hellwig
2024-01-11 16:24 ` Martin K. Petersen
2024-01-11 16:34 ` Mike Snitzer [this message]
2024-01-11 17:07 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaAYgJ+xK6c5p1/L@redhat.com \
--to=snitzer@kernel.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.