From: Yan Zhao <yan.y.zhao@intel.com>
To: Yuan Yao <yuan.yao@linux.intel.com>
Cc: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>, <pbonzini@redhat.com>,
<seanjc@google.com>, <shuah@kernel.org>, <stevensd@chromium.org>
Subject: Re: [RFC PATCH v2 2/3] KVM: selftests: add selftest driver for KVM to test memory slots for MMIO BARs
Date: Fri, 12 Jan 2024 08:21:29 +0800 [thread overview]
Message-ID: <ZaCGCS6xY2KXubf8@yzhao56-desk.sh.intel.com> (raw)
In-Reply-To: <20240110062708.zf3arjmha5czgpzp@yy-desk-7060>
On Wed, Jan 10, 2024 at 02:27:08PM +0800, Yuan Yao wrote:
> > > Do you have plan to allow user to change the bar_size via IOCTL ?
> > > If no "order" and "bar_size" can be removed.
> > >
> > Currently no. But this structure is private to the test driver.
> > What the benefit to remove the two?
>
> It's useless so remove them makes code more easier to understand.
Just my two cents:
Keeping bar_size & order in a device structure is better than spreading
macro BAR_SIZE everywhere and the code is more scalable.
next prev parent reply other threads:[~2024-01-12 0:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 8:43 [RFC PATCH v2 0/3] KVM: allow mapping of compound tail pages for IO or PFNMAP mapping Yan Zhao
2024-01-03 8:44 ` [RFC PATCH v2 1/3] " Yan Zhao
2024-02-13 3:17 ` Sean Christopherson
2024-02-20 8:52 ` Yan Zhao
2024-01-03 8:44 ` [RFC PATCH v2 2/3] KVM: selftests: add selftest driver for KVM to test memory slots for MMIO BARs Yan Zhao
2024-01-04 8:16 ` Yuan Yao
2024-01-05 9:46 ` Yan Zhao
2024-01-10 6:27 ` Yuan Yao
2024-01-12 0:21 ` Yan Zhao [this message]
2024-01-12 5:34 ` Yuan Yao
2024-01-03 8:45 ` [RFC PATCH v2 3/3] KVM: selftests: Add set_memory_region_io to test memslots " Yan Zhao
2024-01-05 6:25 ` Yuan Yao
2024-01-05 10:00 ` Yan Zhao
2024-02-13 3:07 ` [RFC PATCH v2 0/3] KVM: allow mapping of compound tail pages for IO or PFNMAP mapping Sean Christopherson
2024-02-20 8:20 ` Yan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaCGCS6xY2KXubf8@yzhao56-desk.sh.intel.com \
--to=yan.y.zhao@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=stevensd@chromium.org \
--cc=yuan.yao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.