All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: linux-block@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>
Cc: ming.lei@redhat.com, Yi Zhang <yi.zhang@redhat.com>,
	John Meneghini <jmeneghi@redhat.com>,
	linux-nvme@lists.infradead.org, hch@lst.de,
	Keith Busch <kbusch@kernel.org>
Subject: [Report] blk-zoned/ZNS: non_power_of_2 of zone->len]
Date: Fri, 12 Jan 2024 09:13:28 +0800	[thread overview]
Message-ID: <ZaCSOH7L+Nm6PvcN@fedora> (raw)

----- Forwarded message from Ming Lei <ming.lei@redhat.com> -----

Add linux-nvme

Date: Fri, 12 Jan 2024 09:08:47 +0800
From: Ming Lei <ming.lei@redhat.com>
To: linux-block@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>
Cc: ming.lei@redhat.com, Yi Zhang <yi.zhang@redhat.com>, John Meneghini <jmeneghi@redhat.com>
Subject: [Report] blk-zoned/ZNS: non_power_of_2 of zone->len

Hello Damien and Guys,

Yi reported that the following failure:

Oct 18 15:24:15 localhost kernel: nvme nvme4: invalid zone size:196608 for namespace:1
Oct 18 15:24:33 localhost smartd[2303]: Device: /dev/nvme4, opened
Oct 18 15:24:33 localhost smartd[2303]: Device: /dev/nvme4, NETAPPX4022S173A4T0NTZ, S/N:S66NNE0T800169, FW:MVP40B7B, 4.09 TB

Looks current blk-zoned requires zone->len to be power_of_2() since
commit:

6c6b35491422 ("block: set the zone size in blk_revalidate_disk_zones atomically")

And the original power_of_2() requirement is from the following commit
for ZBC and ZAC.

d9dd73087a8b ("block: Enhance blk_revalidate_disk_zones()")

Meantime block layer does support non-power_of_2 chunk sectors limit.

The question is if there is such hard requirement for ZNS, and I can't see
any such words in NVMe Zoned Namespace Command Set Specification.

So is it one NVMe firmware issue? or blk-zoned problem with too strict(power_of_2)
requirement on zone->len?


Thanks,
Ming


----- End forwarded message -----


             reply	other threads:[~2024-01-12  1:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12  1:13 Ming Lei [this message]
2024-01-12  3:05 ` [Report] blk-zoned/ZNS: non_power_of_2 of zone->len] Damien Le Moal
2024-01-12  3:29   ` Ming Lei
2024-01-12  3:34     ` Damien Le Moal
2024-01-12  3:46       ` Bart Van Assche
2024-01-12 15:40     ` Pankaj Raghav (Samsung)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZaCSOH7L+Nm6PvcN@fedora \
    --to=ming.lei@redhat.com \
    --cc=dlemoal@kernel.org \
    --cc=hch@lst.de \
    --cc=jmeneghi@redhat.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=yi.zhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.