From: Matthew Wilcox <willy@infradead.org>
To: Steve French <smfrench@gmail.com>
Cc: David Howells <dhowells@redhat.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Salvatore Bonaccorso <carnil@debian.org>,
Paulo Alcantara <pc@manguebit.com>,
Shyam Prasad N <nspmangalore@gmail.com>,
Rohith Surabattula <rohiths.msft@gmail.com>,
Jeff Layton <jlayton@kernel.org>,
Steve French <stfrench@microsoft.com>,
"Jitindar Singh, Suraj" <surajjs@amazon.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"stable-commits@vger.kernel.org" <stable-commits@vger.kernel.org>,
stable@vger.kernel.org, linux-cifs@vger.kernel.org,
Linux regressions mailing list <regressions@lists.linux.dev>
Subject: Re: [Regression 6.1.y] From "cifs: Fix flushing, invalidation and file size with copy_file_range()"
Date: Sat, 13 Jan 2024 17:02:13 +0000 [thread overview]
Message-ID: <ZaLCFboedRPqcrDO@casper.infradead.org> (raw)
In-Reply-To: <CAH2r5mtBSvp9D8s3bX7KNWjXdTuOHPx5Z005jp8F5kuJgU3Z-g@mail.gmail.com>
On Fri, Jan 12, 2024 at 11:20:53PM -0600, Steve French wrote:
> Here is a patch similar to what David suggested. Seems
Similar to, but worse.
> +++ b/fs/smb/client/cifsfs.c
> @@ -1240,7 +1240,7 @@ static int cifs_flush_folio(struct inode *inode, loff_t pos, loff_t *_fstart, lo
> int rc = 0;
>
> folio = filemap_get_folio(inode->i_mapping, index);
> - if (IS_ERR(folio))
> + if ((!folio) || (IS_ERR(folio)))
> return 0;
filemap_get_folio() cannot return an err_ptr in 6.1, so this should
simply be:
- if (IS_ERR(folio))
+ if (!folio)
next prev parent reply other threads:[~2024-01-13 17:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 12:57 Patch "cifs: Fix flushing, invalidation and file size with copy_file_range()" has been added to the 6.1-stable tree gregkh
2024-01-03 23:40 ` Jitindar Singh, Suraj
2024-01-04 21:59 ` Jitindar Singh, Suraj
2024-01-05 20:50 ` [Regression 6.1.y] From "cifs: Fix flushing, invalidation and file size with copy_file_range()" Salvatore Bonaccorso
2024-01-06 10:40 ` Linux regression tracking (Thorsten Leemhuis)
2024-01-06 11:34 ` Salvatore Bonaccorso
2024-01-06 12:02 ` Linux regression tracking (Thorsten Leemhuis)
2024-01-10 16:20 ` Salvatore Bonaccorso
2024-01-11 11:03 ` gregkh
2024-01-12 8:12 ` Linux regression tracking (Thorsten Leemhuis)
2024-01-12 14:25 ` David Howells
2024-01-13 5:20 ` Steve French
2024-01-13 8:47 ` gregkh
2024-01-13 9:31 ` Salvatore Bonaccorso
2024-01-13 9:41 ` gregkh
2024-01-14 3:23 ` Steve French
2024-01-13 17:02 ` Matthew Wilcox [this message]
2024-01-13 17:08 ` Steve French
2024-01-13 17:51 ` Matthew Wilcox
2024-01-13 20:38 ` Greg KH
2024-01-12 14:21 ` Patch "cifs: Fix flushing, invalidation and file size with copy_file_range()" has been added to the 6.1-stable tree David Howells
2024-01-12 14:26 ` David Howells
2024-01-12 14:44 ` Matthew Wilcox
2024-01-12 14:54 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaLCFboedRPqcrDO@casper.infradead.org \
--to=willy@infradead.org \
--cc=carnil@debian.org \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jlayton@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nspmangalore@gmail.com \
--cc=pc@manguebit.com \
--cc=regressions@lists.linux.dev \
--cc=rohiths.msft@gmail.com \
--cc=smfrench@gmail.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stfrench@microsoft.com \
--cc=surajjs@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.