From: Sasha Levin <sashal@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Mario Limonciello <mario.limonciello@amd.com>,
Marcus Aram <marcus+oss@oxar.nl>,
Mark Herbert <mark.herbert42@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Basavaraj.Natikar@amd.com, Shyam-sundar.S-k@amd.com,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 4.14 3/6] pinctrl: amd: Mask non-wake source pins with interrupt enabled at suspend
Date: Sun, 14 Jan 2024 13:59:36 -0500 [thread overview]
Message-ID: <ZaQvGNNPpgZ5VCfa@sashalap> (raw)
In-Reply-To: <ZZ0xX2Mqx0ezfoWG@duo.ucw.cz>
On Tue, Jan 09, 2024 at 12:43:27PM +0100, Pavel Machek wrote:
>Hi!
>
>> From: Mario Limonciello <mario.limonciello@amd.com>
>>
>> [ Upstream commit 2fff0b5e1a6b9c577b4dd4958902c877159c856b ]
>>
>> If a pin isn't marked as a wake source processing any interrupts is
>> just going to destroy battery life. The APU may wake up from a hardware
>> sleep state to process the interrupt but not return control to the OS.
>>
>> Mask interrupt for all non-wake source pins at suspend. They'll be
>> re-enabled at resume.
>
>Not sure what is going on here, but it is queued for 6.6 and 4.14, but
>not for the kernels between them.
Ack, it should have been dropped from 4.14. Thanks!
--
Thanks,
Sasha
next prev parent reply other threads:[~2024-01-14 18:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 0:27 [PATCH AUTOSEL 4.14 1/6] reset: hisilicon: hi6220: fix Wvoid-pointer-to-enum-cast warning Sasha Levin
2023-12-26 0:27 ` [PATCH AUTOSEL 4.14 2/6] Input: atkbd - skip ATKBD_CMD_GETID in translated mode Sasha Levin
2023-12-26 0:27 ` [PATCH AUTOSEL 4.14 3/6] pinctrl: amd: Mask non-wake source pins with interrupt enabled at suspend Sasha Levin
2024-01-09 11:43 ` Pavel Machek
2024-01-14 18:59 ` Sasha Levin [this message]
2023-12-26 0:27 ` [PATCH AUTOSEL 4.14 4/6] s390/scm: fix virtual vs physical address confusion Sasha Levin
2023-12-26 0:27 ` [PATCH AUTOSEL 4.14 5/6] ARC: fix spare error Sasha Levin
2023-12-26 0:27 ` Sasha Levin
2023-12-26 0:27 ` [PATCH AUTOSEL 4.14 6/6] Input: xpad - add Razer Wolverine V2 support Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaQvGNNPpgZ5VCfa@sashalap \
--to=sashal@kernel.org \
--cc=Basavaraj.Natikar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus+oss@oxar.nl \
--cc=mario.limonciello@amd.com \
--cc=mark.herbert42@gmail.com \
--cc=pavel@ucw.cz \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.