From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
f.fainelli@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: phy: Fix possible NULL pointer dereference issues caused by phy_attached_info_irq
Date: Mon, 15 Jan 2024 11:28:14 +0000 [thread overview]
Message-ID: <ZaUWztbMPhbApPIH@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240115085018.30300-1-chentao@kylinos.cn>
On Mon, Jan 15, 2024 at 04:50:18PM +0800, Kunwu Chan wrote:
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index ed0b4ccaa6a6..819574a06036 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -1886,7 +1886,7 @@ static int phylink_bringup_phy(struct phylink *pl, struct phy_device *phy,
> irq_str = phy_attached_info_irq(phy);
> phylink_info(pl,
> "PHY [%s] driver [%s] (irq=%s)\n",
> - dev_name(&phy->mdio.dev), phy->drv->name, irq_str);
> + dev_name(&phy->mdio.dev), phy->drv->name, irq_str ? irq_str : "");
dev_name(&phy->mdio.dev), phy->drv->name,
irq_str ? irq_str : "");
please.
Also, please hold off posting v3 until at least 24 hours have passed.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2024-01-15 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 8:50 [PATCH net v2] net: phy: Fix possible NULL pointer dereference issues caused by phy_attached_info_irq Kunwu Chan
2024-01-15 11:28 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaUWztbMPhbApPIH@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=chentao@kylinos.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.