From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: linux-input@vger.kernel.org, "Barnabás Pőcze" <pobrn@protonmail.com>
Subject: Re: [PATCH] Input: atkbd - Use ab83 as id when skipping the getid command
Date: Tue, 16 Jan 2024 13:32:12 -0800 [thread overview]
Message-ID: <Zab13OssO_-risMQ@google.com> (raw)
In-Reply-To: <20240116204325.7719-1-hdegoede@redhat.com>
On Tue, Jan 16, 2024 at 09:43:25PM +0100, Hans de Goede wrote:
> Barnabás reported that the change to skip the getid command
> when the controller is in translated mode on laptops caused
> the Version field of his "AT Translated Set 2 keyboard"
> input device to change from ab83 to abba, breaking a custom
> hwdb entry for this keyboard.
>
> Use the standard ab83 id for keyboards when getid is skipped
> (rather then that getid fails) to avoid reporting a different
> Version to userspace then before skipping the getid.
>
> Fixes: 936e4d49ecbc ("Input: atkbd - skip ATKBD_CMD_GETID in translated mode")
> Reported-by: Barnabás Pőcze <pobrn@protonmail.com>
> Closes: https://lore.kernel.org/linux-input/W1ydwoG2fYv85Z3C3yfDOJcVpilEvGge6UGa9kZh8zI2-qkHXp7WLnl2hSkFz63j-c7WupUWI5TLL6n7Lt8DjRuU-yJBwLYWrreb1hbnd6A=@protonmail.com/
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2024-01-16 21:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 20:43 [PATCH] Input: atkbd - Use ab83 as id when skipping the getid command Hans de Goede
2024-01-16 21:32 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zab13OssO_-risMQ@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=pobrn@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.