From: Pavel Machek <pavel@denx.de>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Avadhut Naik <Avadhut.Naik@amd.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tony Luck <tony.luck@intel.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
bleung@chromium.org, tzungbi@kernel.org,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH AUTOSEL 5.10 3/8] platform/chrome: cros_ec_debugfs: Fix permissions for panicinfo
Date: Tue, 16 Jan 2024 21:45:12 +0100 [thread overview]
Message-ID: <Zabq2PKJwsllm9zk@duo.ucw.cz> (raw)
In-Reply-To: <20240116001457.214018-3-sashal@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
Hi!
> From: Avadhut Naik <Avadhut.Naik@amd.com>
>
> [ Upstream commit 0706526ec7704dcd046239078ac175d11a88a95e ]
>
> The debugfs_create_blob() function has been used to create read-only binary
> blobs in debugfs. The function filters out permissions, other than S_IRUSR,
> S_IRGRP and S_IROTH, provided while creating the blobs.
>
> The very behavior though is being changed through previous patch in the
> series (fs: debugfs: Add write functionality to debugfs blobs) which makes
> the binary blobs writable by owners. Thus, all permissions provided while
> creating the blobs, except S_IRUSR,S_IWUSR, S_IRGRP, S_IROTH, will be
> filtered by debugfs_create_blob().
This needs previous patch to make sense (according to changelog), and
we don't have that. Please drop.
BR,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2024-01-16 20:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 0:14 [PATCH AUTOSEL 5.10 1/8] regulator: core: Only increment use_count when enable_count changes Sasha Levin
2024-01-16 0:14 ` [PATCH AUTOSEL 5.10 2/8] audit: Send netlink ACK before setting connection in auditd_set Sasha Levin
2024-01-16 0:14 ` [PATCH AUTOSEL 5.10 3/8] platform/chrome: cros_ec_debugfs: Fix permissions for panicinfo Sasha Levin
2024-01-16 20:45 ` Pavel Machek [this message]
2024-01-30 21:05 ` Sasha Levin
2024-01-16 0:14 ` [PATCH AUTOSEL 5.10 4/8] ACPI: video: Add quirk for the Colorful X15 AT 23 Laptop Sasha Levin
2024-01-16 0:14 ` [PATCH AUTOSEL 5.10 5/8] PNP: ACPI: fix fortify warning Sasha Levin
2024-01-16 0:14 ` [PATCH AUTOSEL 5.10 6/8] ACPI: extlog: fix NULL pointer dereference check Sasha Levin
2024-01-16 0:14 ` [PATCH AUTOSEL 5.10 7/8] PM / devfreq: Synchronize devfreq_monitor_[start/stop] Sasha Levin
2024-01-16 0:14 ` [PATCH AUTOSEL 5.10 8/8] ACPI: APEI: set memory failure flags as MF_ACTION_REQUIRED on synchronous events Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zabq2PKJwsllm9zk@duo.ucw.cz \
--to=pavel@denx.de \
--cc=Avadhut.Naik@amd.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.