From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jozsef Kadlecsik <kadlec@netfilter.org>
Cc: netfilter-devel@vger.kernel.org,
Ale Crismani <ale.crismani@automattic.com>,
David Wang <00107082@163.com>
Subject: Re: [PATCH 1/1] netfilter: ipset: fix performance regression in swap operation
Date: Wed, 17 Jan 2024 13:44:58 +0100 [thread overview]
Message-ID: <ZafLyrzDb29HaX9Q@calendula> (raw)
In-Reply-To: <20240116162956.2517197-2-kadlec@netfilter.org>
On Tue, Jan 16, 2024 at 05:29:56PM +0100, Jozsef Kadlecsik wrote:
> The patch "netfilter: ipset: fix race condition between swap/destroy
> and kernel side add/del/test", commit 28628fa9 fixes a race condition.
> But the synchronize_rcu() added to the swap function unnecessarily slows
> it down: it can safely be moved to destroy and use call_rcu() instead.
> Thus we can get back the same performance and preventing the race condition
> at the same time.
Manually applied this to nf.git, thanks!
next prev parent reply other threads:[~2024-01-17 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 16:29 [PATCH 0/1] ipset performance regression in swap fix Jozsef Kadlecsik
2024-01-16 16:29 ` [PATCH 1/1] netfilter: ipset: fix performance regression in swap operation Jozsef Kadlecsik
2024-01-17 12:44 ` Pablo Neira Ayuso [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-01-29 9:57 [PATCH 0/1] ipset performance regression in swap fix Jozsef Kadlecsik
2024-01-29 9:57 ` [PATCH 1/1] netfilter: ipset: fix performance regression in swap operation Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZafLyrzDb29HaX9Q@calendula \
--to=pablo@netfilter.org \
--cc=00107082@163.com \
--cc=ale.crismani@automattic.com \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.