From: Hangbin Liu <liuhangbin@gmail.com>
To: Taehee Yoo <ap420073@gmail.com>
Cc: Nikita Zhandarovich <n.zhandarovich@fintech.ru>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+a9400cabb1d784e49abf@syzkaller.appspotmail.com
Subject: Re: [PATCH net] ipv6: mcast: fix data-race in ipv6_mc_down / mld_ifc_work
Date: Thu, 18 Jan 2024 17:55:41 +0800 [thread overview]
Message-ID: <Zaj1nZRBkWaDfo-e@Laptop-X1> (raw)
In-Reply-To: <bac390f1-ef6d-317f-a5e1-1c0c5e4e4535@gmail.com>
On Thu, Jan 18, 2024 at 04:24:52PM +0900, Taehee Yoo wrote:
> > I saw mld_process_v1() also cancel these works when changing to v1 mode.
> > Should we also add lock there?
>
> I think mld_process_v1() doesn't have a problem.
> Because mld_process_v1() is always called under mc_lock by mld_query_work().
>
> mld_query_work()
> mutex_lock(&idev->mc_lock);
> __mld_query_work();
> mld_process_v1();
> mutex_unlock(&idev->mc_lock);
Thanks for this info, then this works for me.
Hangbin
next prev parent reply other threads:[~2024-01-18 9:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 17:21 [PATCH net] ipv6: mcast: fix data-race in ipv6_mc_down / mld_ifc_work Nikita Zhandarovich
2024-01-18 2:45 ` Hangbin Liu
2024-01-18 7:24 ` Taehee Yoo
2024-01-18 9:55 ` Hangbin Liu [this message]
2024-01-18 7:11 ` Taehee Yoo
2024-01-18 8:59 ` Eric Dumazet
2024-01-18 13:04 ` Nikita Zhandarovich
2024-01-18 13:28 ` Eric Dumazet
2024-01-18 9:56 ` Hangbin Liu
2024-01-18 18:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zaj1nZRBkWaDfo-e@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=n.zhandarovich@fintech.ru \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+a9400cabb1d784e49abf@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.